-
Notifications
You must be signed in to change notification settings - Fork 268
feat: make plugin version optional - installs latest version #2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
cloud acceptance tests |
a7cdceb
to
1db87f0
Compare
698ab00
to
14b8761
Compare
I kind of wonder whether it would make sense to support |
@DanCech yeah.
If we prefer stability and don't want to auto update, current implementation is fine. But in order to install the latest after the release, user either has to define the version number in the resource.tf |
yeah, I'm thinking that if the user asks for the latest we should keep it up to date, and if they want a specific version they should specify it. Hence the idea of using an explicit |
vs asking for latest and getting whatever it happens to be at install time but then never updating. |
5e985a7
to
2610f7b
Compare
2610f7b
to
7f5f8c4
Compare
7f5f8c4
to
20af507
Compare
@@ -92,10 +95,11 @@ func listStackPlugins(ctx context.Context, client *gcom.APIClient, data *ListerD | |||
func resourcePluginInstallationCreate(ctx context.Context, d *schema.ResourceData, client *gcom.APIClient) diag.Diagnostics { | |||
stackSlug := d.Get("stack_slug").(string) | |||
pluginSlug := d.Get("slug").(string) | |||
version := d.Get("version").(string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaults to latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I don't have particular religion about whether the version param is optional with latest as the default or required.
Fixes #2312
Tested with dev instance on local using locally built provider.
resource.tf