ref: check plugin catalog latest version in read

Author: s4kh

docs/resources/cloud_plugin_installation.md

@@ -41,7 +41,7 @@ resource "grafana_cloud_plugin_installation" "test" {
 
 ### Optional
 
-- `version` (String) Version of the plugin to be installed. When omitted, installs the latest available version at the time of creation. Will not auto-update to newer versions. If you already have a plugin installed and want to upgrade, specify the target version explicitly.
+- `version` (String) Version of the plugin to be installed. Defaults to 'latest' and installs the most recent version. Terraform will detect new version as drift for plan/apply. Defaults to `latest`.
 
 ### Read-Only
 

internal/resources/cloud/resource_cloud_plugin_installation.go

@@ -16,6 +16,8 @@ var (
 	)
 )
 
+const LATEST_VERSION = "latest"
+
 func resourcePluginInstallation() *common.Resource {
 	schema := &schema.Resource{
 		Description: `
@@ -43,9 +45,10 @@ Required access policy scopes:
 				ForceNew:    true,
 			},
 			"version": {
-				Description: "Version of the plugin to be installed. When omitted, installs the latest available version at the time of creation. Will not auto-update to newer versions. If you already have a plugin installed and want to upgrade, specify the target version explicitly.",
+				Description: "Version of the plugin to be installed. Defaults to 'latest' and installs the most recent version. Terraform will detect new version as drift for plan/apply.",
 				Type:        schema.TypeString,
 				Optional:    true,
+				Default:     LATEST_VERSION,
 				ForceNew:    true,
 			},
 		},
@@ -121,10 +124,17 @@ func resourcePluginInstallationRead(ctx context.Context, d *schema.ResourceData,
 	if err, shouldReturn := common.CheckReadError("plugin", d, err); shouldReturn {
 		return err
 	}
+	catalogPlugin, _, err := client.PluginsAPI.GetPlugin(ctx, pluginSlug.(string)).Execute()
+	if err, shouldReturn := common.CheckReadError("plugin", d, err); shouldReturn {
+		return err
+	}
 
 	d.Set("stack_slug", installation.InstanceSlug)
 	d.Set("slug", installation.PluginSlug)
-	if _, ok := d.GetOk("version"); ok {
+	desiredVersion := d.Get("version").(string)
+	if desiredVersion == LATEST_VERSION && installation.Version == catalogPlugin.Version {
+		d.Set("version", LATEST_VERSION)
+	} else {
 		d.Set("version", installation.Version)
 	}
 	d.SetId(resourcePluginInstallationID.Make(stackSlug, pluginSlug))

internal/resources/cloud/resource_cloud_plugin_test.go

@@ -37,14 +37,14 @@ func TestAccResourcePluginInstallation(t *testing.T) {
 					resource.TestCheckResourceAttr("grafana_cloud_plugin_installation.test-installation", "version", "1.2.5")),
 			},
 			{
-				Config: testAccGrafanaCloudPluginInstallationNoVersion(stackSlug, pluginSlug),
+				Config: testAccGrafanaCloudPluginInstallationLatest(stackSlug, "grafana-clock-panel"),
 				Check: resource.ComposeTestCheckFunc(
 					testAccStackCheckExists("grafana_cloud_stack.test", &stack),
-					testAccCloudPluginInstallationCheckExists(stackSlug, pluginSlug),
+					testAccCloudPluginInstallationCheckExists(stackSlug, "grafana-clock-panel"),
 					resource.TestCheckResourceAttrSet("grafana_cloud_plugin_installation.test-installation-no-version", "id"),
 					resource.TestCheckResourceAttr("grafana_cloud_plugin_installation.test-installation-no-version", "stack_slug", stackSlug),
 					resource.TestCheckResourceAttr("grafana_cloud_plugin_installation.test-installation-no-version", "slug", pluginSlug),
-					// Don't check version attribute since it's not specified in config
+					resource.TestCheckResourceAttr("grafana_cloud_plugin_installation.test-installation-no-version", "version", "latest"),
 				),
 			},
 			{
@@ -106,6 +106,7 @@ func testAccGrafanaCloudPluginInstallation(stackSlug, name, version string) stri
 		resource "grafana_cloud_stack" "test" {
 			name  = "%[1]s"
 			slug  = "%[1]s"
+			delete_protection = false
 			wait_for_readiness = false
 		}
 
@@ -117,17 +118,17 @@ func testAccGrafanaCloudPluginInstallation(stackSlug, name, version string) stri
 	`, stackSlug, name, version)
 }
 
-func testAccGrafanaCloudPluginInstallationNoVersion(stackSlug, name string) string {
+func testAccGrafanaCloudPluginInstallationLatest(stackSlug, name string) string {
 	return fmt.Sprintf(`
-        resource "grafana_cloud_stack" "test" {
-            name  = "%[1]s"
-            slug  = "%[1]s"
-            wait_for_readiness = false
-        }
+		resource "grafana_cloud_stack" "test" {
+			name  = "%[1]s"
+			slug  = "%[1]s"
+			delete_protection = false
+			wait_for_readiness = false
+		}
         resource "grafana_cloud_plugin_installation" "test-installation-no-version" {
             stack_slug = grafana_cloud_stack.test.slug
             slug       = "%[2]s"
-            # version omitted - should install latest
         }
     `, stackSlug, name)
 }