feat: make plugin version optional - installs latest version

Author: s4kh

docs/resources/cloud_plugin_installation.md

@@ -38,7 +38,10 @@ resource "grafana_cloud_plugin_installation" "test" {
 
 - `slug` (String) Slug of the plugin to be installed.
 - `stack_slug` (String) The stack id to which the plugin should be installed.
-- `version` (String) Version of the plugin to be installed.
+
+### Optional
+
+- `version` (String) Version of the plugin to be installed, latest version is installed when omitted.
 
 ### Read-Only
 

internal/resources/cloud/resource_cloud_plugin_installation.go

@@ -43,9 +43,9 @@ Required access policy scopes:
 				ForceNew:    true,
 			},
 			"version": {
-				Description: "Version of the plugin to be installed.",
+				Description: "Version of the plugin to be installed, latest version is installed when omitted.",
 				Type:        schema.TypeString,
-				Required:    true,
+				Optional:    true,
 				ForceNew:    true,
 			},
 		},
@@ -89,10 +89,14 @@ func listStackPlugins(ctx context.Context, client *gcom.APIClient, data *ListerD
 func resourcePluginInstallationCreate(ctx context.Context, d *schema.ResourceData, client *gcom.APIClient) diag.Diagnostics {
 	stackSlug := d.Get("stack_slug").(string)
 	pluginSlug := d.Get("slug").(string)
+	version := "latest"
+	if v, ok := d.GetOk("version"); ok {
+		version = v.(string)
+	}
 
 	req := gcom.PostInstancePluginsRequest{
 		Plugin:  pluginSlug,
-		Version: common.Ref(d.Get("version").(string)),
+		Version: common.Ref(version),
 	}
 	_, _, err := client.InstancesAPI.PostInstancePlugins(ctx, stackSlug).
 		PostInstancePluginsRequest(req).
@@ -120,7 +124,9 @@ func resourcePluginInstallationRead(ctx context.Context, d *schema.ResourceData,
 
 	d.Set("stack_slug", installation.InstanceSlug)
 	d.Set("slug", installation.PluginSlug)
-	d.Set("version", installation.Version)
+	if _, ok := d.GetOk("version"); ok {
+		d.Set("version", installation.Version)
+	}
 	d.SetId(resourcePluginInstallationID.Make(stackSlug, pluginSlug))
 
 	return nil

internal/resources/cloud/resource_cloud_plugin_test.go

@@ -36,6 +36,17 @@ func TestAccResourcePluginInstallation(t *testing.T) {
 					resource.TestCheckResourceAttr("grafana_cloud_plugin_installation.test-installation", "slug", "grafana-googlesheets-datasource"),
 					resource.TestCheckResourceAttr("grafana_cloud_plugin_installation.test-installation", "version", "1.2.5")),
 			},
+			{
+				Config: testAccGrafanaCloudPluginInstallationNoVersion(stackSlug, pluginSlug),
+				Check: resource.ComposeTestCheckFunc(
+					testAccStackCheckExists("grafana_cloud_stack.test", &stack),
+					testAccCloudPluginInstallationCheckExists(stackSlug, pluginSlug),
+					resource.TestCheckResourceAttrSet("grafana_cloud_plugin_installation.test-installation-no-version", "id"),
+					resource.TestCheckResourceAttr("grafana_cloud_plugin_installation.test-installation-no-version", "stack_slug", stackSlug),
+					resource.TestCheckResourceAttr("grafana_cloud_plugin_installation.test-installation-no-version", "slug", pluginSlug),
+					// Don't check version attribute since it's not specified in config
+				),
+			},
 			{
 				ResourceName:      "grafana_cloud_plugin_installation.test-installation",
 				ImportState:       true,
@@ -105,3 +116,18 @@ func testAccGrafanaCloudPluginInstallation(stackSlug, name, version string) stri
 		}
 	`, stackSlug, name, version)
 }
+
+func testAccGrafanaCloudPluginInstallationNoVersion(stackSlug, name string) string {
+	return fmt.Sprintf(`
+        resource "grafana_cloud_stack" "test" {
+            name  = "%[1]s"
+            slug  = "%[1]s"
+            wait_for_readiness = false
+        }
+        resource "grafana_cloud_plugin_installation" "test-installation-no-version" {
+            stack_slug = grafana_cloud_stack.test.slug
+            slug       = "%[2]s"
+            # version omitted - should install latest
+        }
+    `, stackSlug, name)
+}