Skip to content

Conversation

audgirka
Copy link
Contributor

@audgirka audgirka commented Jan 18, 2024

  • Fixed key error for name[casing] rule.
  • Fixed yaml_path issue for nested tasks under always block

Incorrect yaml_path was being generated earlier.
This PR fixes the same and ensures we get the correct task when we have multiple blocks like block and always within the same yaml file.

Fixes #3973

@audgirka audgirka requested a review from a team as a code owner January 18, 2024 09:18
@audgirka audgirka requested review from priyamsahoo and shatakshiiii and removed request for a team January 18, 2024 09:18
@github-actions github-actions bot added the bug label Jan 18, 2024
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ssbarnea ssbarnea merged commit e53aa16 into main Jan 18, 2024
@ssbarnea ssbarnea deleted the fix/name_casing_key_error branch January 18, 2024 11:02
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Jan 20, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | patch | `==6.22.1` -> `==6.22.2` |

---

### Release Notes

<details>
<summary>ansible/ansible-lint (ansible-lint)</summary>

### [`v6.22.2`](https://github.com/ansible/ansible-lint/releases/tag/v6.22.2)

[Compare Source](ansible/ansible-lint@v6.22.1...v6.22.2)

#### Bugfixes

-   Fix key error for name\[casing] rule ([#&#8203;3987](ansible/ansible-lint#3987)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Allow dashes in legacy role namespaces ([#&#8203;3962](ansible/ansible-lint#3962)) [@&#8203;sur5r](https://github.com/sur5r)
-   Use new ansible-compat verbosity levels ([#&#8203;3975](ansible/ansible-lint#3975)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Remove dependency on newer requests library ([#&#8203;3959](ansible/ansible-lint#3959)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Ignore set-property for systemd command ([#&#8203;3949](ansible/ansible-lint#3949)) [@&#8203;alanbbr](https://github.com/alanbbr)
-   Correct requires_ansible error message ([#&#8203;3954](ansible/ansible-lint#3954)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Improve transformation for `no-free-form` rule ([#&#8203;3945](ansible/ansible-lint#3945)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Documentation improvement ([#&#8203;3946](ansible/ansible-lint#3946)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   docs: fix grammatical issue in philosophy Q\&A section ([#&#8203;3934](ansible/ansible-lint#3934)) [@&#8203;davidhulick](https://github.com/davidhulick)
-   Update supported versions of ansible ([#&#8203;3930](ansible/ansible-lint#3930)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Fix backward compatibility ([#&#8203;3929](ansible/ansible-lint#3929)) [@&#8203;McSim85](https://github.com/McSim85)
-   Fix auto capitalization for name\[prefix] rule ([#&#8203;3922](ansible/ansible-lint#3922)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Fix role deps check for detecting path names ([#&#8203;3923](ansible/ansible-lint#3923)) [@&#8203;cavcrosby](https://github.com/cavcrosby)
-   Avoid warnings about PATH with pipx installations ([#&#8203;3920](ansible/ansible-lint#3920)) [@&#8203;ssbarnea](https://github.com/ssbarnea)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/319
Co-authored-by: Renovate <[email protected]>
Co-committed-by: Renovate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Key error when scanning repository
2 participants