Fix key error for name[casing] rule (#3987)

Author: audgirka

.github/workflows/tox.yml

@@ -69,7 +69,7 @@ jobs:
     env:
       # Number of expected test passes, safety measure for accidental skip of
       # tests. Update value if you add/remove tests.
-      PYTEST_REQPASS: 850
+      PYTEST_REQPASS: 851
     steps:
       - uses: actions/checkout@v4
         with:

examples/roles/name_casing/tasks/main.transformed.yml

@@ -0,0 +1,15 @@
+---
+- name: Test nested tasks within block and always
+  block:
+    - name: Test1
+      ansible.builtin.debug:
+        msg: Foo
+
+    - name: Test2
+      ansible.builtin.debug:
+        msg: Bar
+
+  always:
+    - name: From always block to be auto fixed as name[casing] scenario
+      ansible.builtin.debug:
+        msg: Baz

examples/roles/name_casing/tasks/main.yml

@@ -0,0 +1,15 @@
+---
+- name: Test nested tasks within block and always
+  block:
+    - name: test1
+      ansible.builtin.debug:
+        msg: Foo
+
+    - name: Test2
+      ansible.builtin.debug:
+        msg: Bar
+
+  always:
+    - name: from always block to be auto fixed as name[casing] scenario
+      ansible.builtin.debug:
+        msg: Baz

src/ansiblelint/rules/name.py

@@ -174,17 +174,16 @@ def transform(
         if match.tag == "name[casing]":
             target_task = self.seek(match.yaml_path, data)
             # Not using capitalize(), since that rewrites the rest of the name to lower case
-            task_name = target_task["name"]
-            if "|" in task_name:  # if using prefix
-                [file_name, update_task_name] = task_name.split("|")
-                target_task[
-                    "name"
-                ] = f"{file_name.strip()} | {update_task_name.strip()[:1].upper()}{update_task_name.strip()[1:]}"
-            else:
-                target_task[
-                    "name"
-                ] = f"{target_task['name'][:1].upper()}{target_task['name'][1:]}"
-            match.fixed = True
+            task_name = target_task.get("name", None)
+            if task_name:
+                if "|" in task_name:  # if using prefix
+                    [file_name, update_task_name] = task_name.split("|")
+                    target_task[
+                        "name"
+                    ] = f"{file_name.strip()} | {update_task_name.strip()[:1].upper()}{update_task_name.strip()[1:]}"
+                else:
+                    target_task["name"] = f"{task_name[:1].upper()}{task_name[1:]}"
+                match.fixed = True
 
 
 if "pytest" in sys.modules:

src/ansiblelint/schemas/__store__.json

@@ -24,7 +24,7 @@
     "url": "https://raw.githubusercontent.com/ansible/ansible-lint/main/src/ansiblelint/schemas/inventory.json"
   },
   "meta": {
-    "etag": "097a20155bc7936b6eae292a556bb38202d34a0a333ff5cbaaa1b4d3a4cc7bf5",
+    "etag": "fb58deb0f5f2a3b77ba298764f74bc6e3bd38a761f368a50bb285042f6260354",
     "url": "https://raw.githubusercontent.com/ansible/ansible-lint/main/src/ansiblelint/schemas/meta.json"
   },
   "meta-runtime": {

src/ansiblelint/yaml_utils.py

@@ -422,6 +422,8 @@ def _get_path_to_task_in_nested_tasks_block(
             continue
         next_task_key = task_keys_by_index.get(task_index + 1, None)
         if next_task_key is not None:
+            if task.lc.data[next_task_key][2] < lineno:
+                continue
             next_task_key_line_index = task.lc.data[next_task_key][0]
         else:
             next_task_key_line_index = None

test/test_transformer.py

@@ -174,7 +174,14 @@ def fixture_runner_result(
             1,
             True,
             True,
-            id="name_case_with_prefix",
+            id="name_casing_prefix",
+        ),
+        pytest.param(
+            "examples/roles/name_casing/tasks/main.yml",
+            2,
+            True,
+            True,
+            id="name_case",
         ),
     ),
 )