Skip to content

Correct requires_ansible error message #3954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 20, 2023
Merged

Correct requires_ansible error message #3954

merged 4 commits into from
Dec 20, 2023

Conversation

ssbarnea
Copy link
Member

Related: #3950

@ssbarnea ssbarnea requested a review from a team as a code owner December 20, 2023 14:30
@ssbarnea ssbarnea requested review from priyamsahoo and shatakshiiii and removed request for a team December 20, 2023 14:30
@ssbarnea ssbarnea added the bug label Dec 20, 2023
Qalthos
Qalthos requested changes Dec 20, 2023
View reviewed changes
Qalthos
Qalthos previously requested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh now I see you added the comprehension above. It feels a little unwieldy to include the ">=", but it is at least illustrative.

@ssbarnea ssbarnea requested a review from Qalthos December 20, 2023 15:02
@ssbarnea ssbarnea dismissed Qalthos’s stale review December 20, 2023 15:03

Please check it again, I also updated the docs.

Qalthos
Qalthos requested changes Dec 20, 2023
View reviewed changes
@ssbarnea ssbarnea mentioned this pull request Dec 20, 2023
Closed
@ssbarnea ssbarnea requested a review from Qalthos December 20, 2023 15:18
@ssbarnea ssbarnea merged commit 31af5c8 into main Dec 20, 2023
@ssbarnea ssbarnea deleted the fix/mkdocs branch December 20, 2023 16:32
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Jan 20, 2024
@nrdufour
chore(deps): update dependency ansible-lint to v6.22.2 (#319)
ebd3adc 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | patch | `==6.22.1` -> `==6.22.2` |

---

### Release Notes

<details>
<summary>ansible/ansible-lint (ansible-lint)</summary>

### [`v6.22.2`](https://github.com/ansible/ansible-lint/releases/tag/v6.22.2)

[Compare Source](ansible/ansible-lint@v6.22.1...v6.22.2)

#### Bugfixes

-   Fix key error for name\[casing] rule ([#&#8203;3987](ansible/ansible-lint#3987)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Allow dashes in legacy role namespaces ([#&#8203;3962](ansible/ansible-lint#3962)) [@&#8203;sur5r](https://github.com/sur5r)
-   Use new ansible-compat verbosity levels ([#&#8203;3975](ansible/ansible-lint#3975)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Remove dependency on newer requests library ([#&#8203;3959](ansible/ansible-lint#3959)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Ignore set-property for systemd command ([#&#8203;3949](ansible/ansible-lint#3949)) [@&#8203;alanbbr](https://github.com/alanbbr)
-   Correct requires_ansible error message ([#&#8203;3954](ansible/ansible-lint#3954)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Improve transformation for `no-free-form` rule ([#&#8203;3945](ansible/ansible-lint#3945)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Documentation improvement ([#&#8203;3946](ansible/ansible-lint#3946)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   docs: fix grammatical issue in philosophy Q\&A section ([#&#8203;3934](ansible/ansible-lint#3934)) [@&#8203;davidhulick](https://github.com/davidhulick)
-   Update supported versions of ansible ([#&#8203;3930](ansible/ansible-lint#3930)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Fix backward compatibility ([#&#8203;3929](ansible/ansible-lint#3929)) [@&#8203;McSim85](https://github.com/McSim85)
-   Fix auto capitalization for name\[prefix] rule ([#&#8203;3922](ansible/ansible-lint#3922)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Fix role deps check for detecting path names ([#&#8203;3923](ansible/ansible-lint#3923)) [@&#8203;cavcrosby](https://github.com/cavcrosby)
-   Avoid warnings about PATH with pipx installations ([#&#8203;3920](ansible/ansible-lint#3920)) [@&#8203;ssbarnea](https://github.com/ssbarnea)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/319
Co-authored-by: Renovate <[email protected]>
Co-committed-by: Renovate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
None yet
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssbarnea @Qalthos