Skip to content

Conversation

a2a-bot
Copy link
Collaborator

@a2a-bot a2a-bot commented Aug 13, 2025

🤖 I have created a release beep boop

0.3.2 (2025-08-20)

Bug Fixes

  • Add missing mime_type and name in proto conversion utils (#408) (72b2ee7)
  • Add name field to FilePart protobuf message (#403) (1dbe33d)
  • Client hangs when implementing AgentExecutor and awaiting twice in execute method (#379) (c147a83)
  • grpc: Update CreateTaskPushNotificationConfig endpoint to /v1/{parent=tasks/*/pushNotificationConfigs} (#415) (73dddc3)
  • make event_consumer tolerant to closed queues on py3.13 (#407) (a371461)
  • non-blocking send_message server handler not invoke push notification (#394) (db82a65)
  • proto: Add icon_url to a2a.proto (#416) (00703e3)
  • spec: Suggest Unique Identifier fields to be UUID (#405) (da14cea)

This PR was generated with Release Please. See documentation.

@a2a-bot a2a-bot requested a review from a team as a code owner August 13, 2025 15:56
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the release of version 0.3.2, primarily incorporating a critical bug fix. The update ensures that the FilePart protobuf message now correctly includes a 'name' field, resolving a previously identified issue and enhancing data serialization capabilities.

Highlights

  • Automated Release: This pull request is an automated release for version 0.3.2, generated by the Release Please tool.
  • Bug Fix: A bug fix has been included to add a 'name' field to the FilePart protobuf message, addressing issue #403.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CHANGELOG.md for the 0.3.2 release. The main change is adding a name field to the FilePart protobuf message.

However, I've found a critical bug in the implementation. The conversion logic in src/a2a/utils/proto_utils.py for ToProto.file and FromProto.file was not updated to handle the new name field or the existing mime_type field. This will cause these fields to be lost during data conversion.

Since the file is not in the diff, I'm providing the fix here and recommend creating a follow-up PR to apply it.

In src/a2a/utils/proto_utils.py, ToProto.file should be:

@classmethod
def file(cls, file: types.FileWithUri | types.FileWithBytes) -> a2a_pb2.FilePart:
    common_args = {'mime_type': file.mime_type, 'name': file.name}
    if isinstance(file, types.FileWithUri):
        return a2a_pb2.FilePart(file_with_uri=file.uri, **common_args)
    return a2a_pb2.FilePart(file_with_bytes=file.bytes.encode('utf-8'), **common_args)

And FromProto.file should be:

@classmethod
def file(cls, file: a2a_pb2.FilePart) -> types.FileWithUri | types.FileWithBytes:
    common_args = {'mime_type': file.mime_type or None, 'name': file.name or None}
    if file.HasField('file_with_uri'):
        return types.FileWithUri(uri=file.file_with_uri, **common_args)
    return types.FileWithBytes(bytes=file.file_with_bytes.decode('utf-8'), **common_args)

@a2a-bot a2a-bot force-pushed the release-please--branches--main branch from 92f721e to a38bb0b Compare August 15, 2025 16:23
@pwwpche
Copy link
Contributor

pwwpche commented Aug 15, 2025

Gemini predict exactly what I'd like to fix

#408

Could we pick up the pull request above in the 0.3.2 release?

@a2a-bot a2a-bot force-pushed the release-please--branches--main branch from a38bb0b to 484461d Compare August 20, 2025 19:55
@holtskinner holtskinner merged commit 5912b28 into main Aug 20, 2025
8 checks passed
@holtskinner holtskinner deleted the release-please--branches--main branch August 20, 2025 20:04
@a2a-bot
Copy link
Collaborator Author

a2a-bot commented Aug 20, 2025

🤖 Created releases:

🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants