Add options to always approve write and execute operations #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 3c8a9c0 in 11 minutes and 23 seconds
More details
- Looked at
963lines of code in10files - Skipped
1files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. src/core/Cline.ts:1119
- Draft comment:
Consider refactoring the repeated logic for checkingalwaysAllowWriteandalwaysAllowExecutebefore callingaskApprovalinto a separate function to improve code readability and maintainability. This pattern is repeated in several places, such as lines 1119, 1527, and 1510. - Reason this comment was not posted:
Confidence changes required:50%
The code inCline.tshas multiple instances where theaskApprovalfunction is used to check for user approval before proceeding with certain actions. However, the logic for checkingalwaysAllowWriteandalwaysAllowExecuteis repeated multiple times. This can be refactored to improve code readability and maintainability.
2. src/core/Cline.ts:1507
- Draft comment:
Consider refactoring the repeated logic for handlingalwaysAllowWrite,alwaysAllowExecute, andalwaysAllowReadOnlyflags into a helper function or shared utility to reduce redundancy. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
3. src/core/Cline.ts:1116
- Draft comment:
Consider refactoring the repeated logic for handlingalwaysAllowWrite,alwaysAllowExecute, andalwaysAllowReadOnlyflags into a helper function or shared utility to reduce redundancy. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
4. src/core/Cline.ts:1093
- Draft comment:
Consider refactoring the repeated logic for handlingalwaysAllowWrite,alwaysAllowExecute, andalwaysAllowReadOnlyflags into a helper function or shared utility to reduce redundancy. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
5. src/core/Cline.ts:110
- Draft comment:
Consider refactoring the repeated logic for handlingalwaysAllowWrite,alwaysAllowExecute, andalwaysAllowReadOnlyflags into a helper function or shared utility to reduce redundancy. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
6. src/core/Cline.ts:96
- Draft comment:
Consider refactoring the repeated logic for handlingalwaysAllowWrite,alwaysAllowExecute, andalwaysAllowReadOnlyflags into a helper function or shared utility to reduce redundancy. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_Cbit47NFizGGxsdB
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -1052,7 +1059,11 @@ export class Cline { | |||
| if (block.partial) { | |||
There was a problem hiding this comment.
Consider refactoring the repeated logic for handling alwaysAllowWrite, alwaysAllowExecute, and alwaysAllowReadOnly flags into a helper function or shared utility to reduce redundancy. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5. This applies to other instances in this file as well.
src/core/webview/ClineProvider.ts
Outdated
| @@ -45,6 +45,8 @@ type GlobalStateKey = | |||
| | "lastShownAnnouncementId" | |||
| | "customInstructions" | |||
| | "alwaysAllowReadOnly" | |||
There was a problem hiding this comment.
The constant alwaysAllowWrite is already defined in the codebase, making this a duplicate. Please use the existing definition in src/core/Cline.ts or src/core/webview/ClineProvider.ts. Avoid redundancy.
- constant
alwaysAllowWrite(Cline.ts) - constant
alwaysAllowWrite(ClineProvider.ts)
7 tasks
mrubens
pushed a commit
that referenced
this pull request
Mar 5, 2025
Syncing sbc-roo-code main branch
Merged
23 tasks
roomote-agent
pushed a commit
that referenced
this pull request
Jul 8, 2025
1 task
4 tasks
4 tasks
roomote bot
pushed a commit
that referenced
this pull request
Sep 4, 2025
… tools Fixes issue where isWriteProtected was incorrectly passed as the partial flag to task.ask(), causing "Current ask promise was ignored (#1)" error. Both tools now use the askApproval wrapper function which correctly handles the parameter ordering, passing undefined for progressStatus and isWriteProtected as the fourth parameter. Fixes #7648
mrubens
pushed a commit
that referenced
this pull request
Sep 4, 2025
… tools (#7649) Fixes issue where isWriteProtected was incorrectly passed as the partial flag to task.ask(), causing "Current ask promise was ignored (#1)" error. Both tools now use the askApproval wrapper function which correctly handles the parameter ordering, passing undefined for progressStatus and isWriteProtected as the fourth parameter. Fixes #7648 Co-authored-by: Roo Code <[email protected]>
mtone
pushed a commit
to mtone/Roo-Code
that referenced
this pull request
Sep 7, 2025
… tools (RooCodeInc#7649) Fixes issue where isWriteProtected was incorrectly passed as the partial flag to task.ask(), causing "Current ask promise was ignored (RooCodeInc#1)" error. Both tools now use the askApproval wrapper function which correctly handles the parameter ordering, passing undefined for progressStatus and isWriteProtected as the fourth parameter. Fixes RooCodeInc#7648 Co-authored-by: Roo Code <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add setting to always approve write and execute operations.
Related Issues
N/A
Type of Change
Screenshots/How Has This Been Tested?
New settings UI:
Example task which doesn't prompt for write or execute permissions: