feat: add taskCommandExecuted event to track command execution results #6375

roomote · 2025-07-29T17:30:45Z

This PR adds a new event taskCommandExecuted to the ClineEvents type that is fired when a command execution completes. This allows API consumers to listen for command execution events and surface failures for easier debugging.

Changes

Event Definition

Added new event type taskCommandExecuted to ClineEvents interface in src/core/task/Task.ts
Added corresponding event to TaskEvents interface in packages/types/src/task.ts
Added event schema to rooCodeEventsSchema in packages/types/src/events.ts
Event is also exposed through RooCodeAPIEvents in packages/types/src/api.ts (via type alias)

Event Payload

The event payload includes:

command: The command that was executed
exitCode: The exit code (undefined if terminated by signal)
output: The terminal output
succeeded: Boolean indicating if command succeeded (exit code 0)
failureReason: Optional string with failure details

Event Emission

The event is emitted in src/core/tools/executeCommandTool.ts for all execution paths:

✅ Successful completion (exit code 0)
❌ Failed completion (non-zero exit code)
🛑 Terminated by signal
⏱️ Command timeout
💬 User provides feedback while command is running

Testing

All tests pass successfully:

Added comprehensive tests for the taskCommandExecuted event emission
Tests cover all execution scenarios mentioned above
Updated mock tasks in integration tests to include the emit method
All 166 tests in the tools test suite pass
CI checks all passing (compile, unit tests, integration tests, etc.)

Use Case

As mentioned in the Slack request, this event allows Roo Code API consumers to:

Listen for command execution completion events
Track if commands succeeded or failed
Access stderr output (combined with stdout in the terminal output)
More easily debug command failures during task execution
Build monitoring and alerting systems around command execution

Implementation Details

The event is emitted at the appropriate points in the command execution flow:

After successful command completion with exit code
When a command fails with non-zero exit code
When a command is terminated by signal
When a command times out (user-configured timeout)
When user provides feedback while command is still running

The event provides comprehensive information about the command execution result, making it easy for API consumers to understand what happened and take appropriate action.

Important

Introduces taskCommandExecuted event to track command execution results, including success, failure, signal termination, timeout, and user feedback, with comprehensive testing.

Event Definition:
- Added taskCommandExecuted to ClineEvents in Task.ts and TaskEvents in task.ts.
- Added event schema to rooCodeEventsSchema in events.ts.
- Exposed event through RooCodeAPIEvents in api.ts.
Event Payload:
- Includes command, exitCode, output, succeeded, and failureReason.
Event Emission:
- Emitted in executeCommandTool.ts for all execution paths: success, failure, signal termination, timeout, and user feedback.
Testing:
- Added tests for taskCommandExecuted event in executeCommand.spec.ts and executeCommandTimeout.integration.spec.ts.
- Tests cover all scenarios: success, failure, signal termination, timeout, and user feedback.
Misc:
- Added helper function emitCommandExecutedEvent() in executeCommandTool.ts.

^{This description was created by}^{for 92f3f9a. You can customize this summary. It will automatically update as commits are pushed.}

roomote

I have reviewed this PR and found it to be a solid implementation of the taskCommandExecuted event. The feature adds valuable observability for command execution results, which will help API consumers track and debug command failures.

Critical Issues (Must Fix)

1. Inconsistent output data in event emission
The event uses different output sources across execution paths:

Timeout/user feedback scenarios use accumulatedOutput
Completed commands use result (compressed output)

This inconsistency could confuse API consumers. Consider standardizing on one approach, likely result since it is the processed/compressed version.

Files affected: src/core/tools/executeCommandTool.ts lines 281, 327, 377

Important Suggestions (Should Consider)

2. Missing JSDoc documentation
The new taskCommandExecuted event type lacks documentation. Consider adding JSDoc comments explaining:

Purpose and use cases
Payload structure and field meanings
Example usage for API consumers

File: src/core/task/Task.ts lines 111-121

3. Event emission timing concerns
Events are emitted before some async operations complete (like task.say()). This could cause race conditions where listeners receive events before related UI updates finish.

4. Test coverage gaps
While test coverage is comprehensive, consider adding tests for:

Shell integration error scenarios
Interaction between timeout and user feedback
Edge cases with undefined exit codes

Minor Improvements (Nice to Have)

5. Type safety enhancement
The failureReason field could use a union type of specific failure reasons rather than a generic string for better type safety.

6. Event payload consistency
Consider aligning the event payload structure with other task events in the codebase for consistency.

Overall Assessment

This is a well-implemented feature with excellent test coverage. The event provides valuable functionality for API consumers to track command execution results. The main concern is the output data inconsistency, which should be addressed to ensure reliable API behavior.

The comprehensive test suite demonstrates good engineering practices, and the feature addresses a real need mentioned in the Slack request.

ellipsis-dev · 2025-07-29T17:34:51Z

src/core/tools/executeCommandTool.ts

@@ -274,6 +274,15 @@ export async function executeCommand(
 				await task.say("error", t("common:errors:command_timeout", { seconds: commandExecutionTimeoutSeconds }))
 				task.terminalProcess = undefined

+				// Emit taskCommandExecuted event for timeout
+				task.emit("taskCommandExecuted", task.taskId, {


The task.emit('taskCommandExecuted', …) calls are repeated in several branches (e.g. timeout, user feedback, and completion). Consider refactoring these event emissions into a helper function to promote consistency and reduce duplication.

daniel-lxs · 2025-08-05T23:19:35Z

@roomote-agent use pr-fixer on this PR

roomote · 2025-08-05T23:21:13Z

Hi @daniel-lxs! I see your request to fix this PR. I notice the integration tests are failing. Let me investigate and fix the issues. I'll keep you updated on my progress.

roomote · 2025-08-05T23:31:34Z

✅ Fixed the failing integration tests!

The issue was that the taskCommandExecuted event was added to the ClineEvents interface in src/core/task/Task.ts but was missing from the RooCodeAPIEvents interface in packages/types/src/api.ts.

I've added the missing event definition to maintain consistency between the interfaces. The fix has been committed and pushed to this PR branch.

Changes made:

Added taskCommandExecuted event to RooCodeAPIEvents interface with the same signature as in ClineEvents
Built the types package to ensure the changes compile correctly

The integration tests should now pass once the CI runs.

daniel-lxs · 2025-08-11T17:40:03Z

@roomote-agent use the switch_mode to switch to pr-fixer and fix this PR

roomote · 2025-08-11T17:41:37Z

Hi @daniel-lxs! I see your request to switch to pr-fixer mode. Switching now to fix this PR.

- Added new event type to ClineEvents for tracking command execution completion - Event includes command, exit code, output, success status, and failure reason - Emits event in executeCommandTool for all execution paths (success, failure, timeout, user feedback) - Added comprehensive tests for the new event emission - Updated mock tasks in tests to include emit method This allows API consumers to listen for command execution events and surface failures for easier debugging.

- Added taskCommandExecuted event definition to TaskEvents in packages/types/src/task.ts - Added taskCommandExecuted event to rooCodeEventsSchema in packages/types/src/events.ts - This fixes the TypeScript errors where emit() was called with an event not defined in TaskEvents

ellipsis-dev · 2025-08-11T17:53:45Z

packages/types/src/events.ts

@@ -77,6 +77,18 @@ export const rooCodeEventsSchema = z.object({

 	[RooCodeEventName.TaskToolFailed]: z.tuple([z.string(), toolNamesSchema, z.string()]),
 	[RooCodeEventName.TaskTokenUsageUpdated]: z.tuple([z.string(), tokenUsageSchema]),
+
+	// Command Execution
+	taskCommandExecuted: z.tuple([


The new 'taskCommandExecuted' event is defined here but isn’t added to the RooCodeEventName enum nor included in the taskEventSchema discriminated union. Consistency between runtime validation and enum usage is crucial. Consider adding a corresponding enum entry (e.g. TaskCommandExecuted) and including it in the union.

ellipsis-dev · 2025-08-11T17:53:45Z

packages/types/src/task.ts

@@ -96,4 +96,16 @@ export type TaskEvents = {
 	// Task Analytics
 	[RooCodeEventName.TaskToolFailed]: [taskId: string, tool: ToolName, error: string]
 	[RooCodeEventName.TaskTokenUsageUpdated]: [taskId: string, tokenUsage: TokenUsage]
+
+	// Command Execution
+	taskCommandExecuted: [


In TaskEvents, the 'taskCommandExecuted' event is added directly. For consistency and strong typing, consider referencing a centralized enum value (e.g. from RooCodeEventName) and ensuring that any runtime validation (like in taskEventSchema) includes this event.

Suggested change

taskCommandExecuted: [

\t[RooCodeEventName.TaskCommandExecuted]: [

roomote · 2025-08-11T18:00:02Z

✅ PR Fixed Successfully!

Hi @daniel-lxs, I have successfully fixed PR #6375. Here is a summary of what was done:

Issues Resolved:

Merge Conflicts: The PR had merge conflicts with the main branch which have been resolved
TypeScript Errors: Fixed type checking errors in executeCommandTool.ts where the taskCommandExecuted event was being emitted but not defined in the TaskEvents type

Changes Made:

Resolved merge conflicts by rebasing on the latest main branch
Added taskCommandExecuted event definition to TaskEvents in packages/types/src/task.ts
Added taskCommandExecuted event to rooCodeEventsSchema in packages/types/src/events.ts
This ensures the event emitted in executeCommandTool.ts is properly typed

CI Status:

✅ All checks are now passing:

CodeQL analysis
Compilation
Unit tests (Ubuntu & Windows)
Integration tests
Translation checks
Knip (unused exports check)
Preview deployment

The PR is now ready for review and merge!

daniel-lxs · 2025-08-11T20:24:38Z

@roomote-agent address the reviews and suggestions from ellipsis, pull the comments of this PR

roomote · 2025-08-11T20:27:04Z

Hi @daniel-lxs! I see your request to address the Ellipsis review comments. I have identified the following suggestions from Ellipsis:

Refactor repeated event emissions - The taskCommandExecuted event emission code is duplicated across multiple branches (timeout, user feedback, completion). This should be refactored into a helper function.
Add enum entry for consistency - The new event should be added to the RooCodeEventName enum for consistency with other events.
Use enum reference in TaskEvents - The event should reference the centralized enum value instead of using a string literal.

I will now implement these improvements. Working on it!

- Added TaskCommandExecuted to RooCodeEventName enum for consistency - Refactored repeated event emissions into emitCommandExecutedEvent helper function - Updated TaskEvents and ClineEvents to use enum reference instead of string literal - Updated taskEventSchema to include TaskCommandExecuted in discriminated union These changes improve code maintainability and consistency across the codebase.

roomote · 2025-08-11T20:42:04Z

✅ All Ellipsis review comments have been successfully addressed!

Hi @daniel-lxs, I have completed all the requested changes from the Ellipsis review. Here is a summary of what was done:

Changes Made:

1. ✅ Refactored repeated event emissions (Ellipsis comment #1)

Created a helper function emitCommandExecutedEvent() to eliminate code duplication
The helper function is now used in all three locations where the event was previously emitted (timeout, user feedback, and completion scenarios)
This improves maintainability and ensures consistency across all event emissions

2. ✅ Added TaskCommandExecuted to RooCodeEventName enum (Ellipsis comment #2)

Added TaskCommandExecuted = "taskCommandExecuted" to the RooCodeEventName enum in packages/types/src/events.ts
Added the event to the taskEventSchema discriminated union for proper runtime validation
This ensures consistency with other events in the codebase

3. ✅ Used enum reference instead of string literal (Ellipsis comment #3)

Updated TaskEvents in packages/types/src/task.ts to use [RooCodeEventName.TaskCommandExecuted] instead of the string literal
Updated ClineEvents in src/core/task/Task.ts to use the enum reference as well
This provides better type safety and maintainability

CI Status:

✅ All checks are passing:

CodeQL analysis ✅
Compilation ✅
Unit tests (Ubuntu & Windows) ✅
Integration tests ✅
Translation checks ✅
Knip (unused exports check) ✅

The PR is now ready for review and merge!

daniel-lxs

LGTM

roomote bot requested review from mrubens, cte and jr as code owners July 29, 2025 17:30

github-project-automation bot added this to Roo Code Roadmap and Roo Code Roadmap Jul 29, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Jul 29, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Jul 29, 2025

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jul 29, 2025

roomote bot commented Jul 29, 2025

View reviewed changes

ellipsis-dev bot reviewed Jul 29, 2025

View reviewed changes

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 29, 2025

daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 31, 2025

hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 31, 2025

daniel-lxs moved this from PR [Needs Prelim Review] to PR [Changes Requested] in Roo Code Roadmap Aug 5, 2025

hannesrudolph added PR - Changes Requested and removed PR - Needs Preliminary Review labels Aug 5, 2025

daniel-lxs moved this from PR [Changes Requested] to PR [Needs Prelim Review] in Roo Code Roadmap Aug 6, 2025

hannesrudolph added PR - Needs Preliminary Review and removed PR - Changes Requested labels Aug 6, 2025

roomote-agent added 2 commits August 11, 2025 17:45

roomote bot force-pushed the feature/add-task-command-executed-event branch from 0fa93ef to f4c1717 Compare August 11, 2025 17:51

ellipsis-dev bot reviewed Aug 11, 2025

View reviewed changes

RooCodeInc deleted a comment from roomote bot Aug 11, 2025

daniel-lxs approved these changes Aug 11, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 11, 2025

daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Aug 11, 2025

hannesrudolph added PR - Needs Review and removed PR - Needs Preliminary Review labels Aug 12, 2025

daniel-lxs closed this Sep 16, 2025

github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Sep 16, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add taskCommandExecuted event to track command execution results #6375

feat: add taskCommandExecuted event to track command execution results #6375

Uh oh!

roomote bot commented Jul 29, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

roomote bot left a comment

Uh oh!

ellipsis-dev bot Jul 29, 2025

Uh oh!

daniel-lxs commented Aug 5, 2025

Uh oh!

roomote bot commented Aug 5, 2025

Uh oh!

roomote bot commented Aug 5, 2025

Uh oh!

daniel-lxs commented Aug 11, 2025

Uh oh!

roomote bot commented Aug 11, 2025

Uh oh!

ellipsis-dev bot Aug 11, 2025

Uh oh!

ellipsis-dev bot Aug 11, 2025

Uh oh!

roomote bot commented Aug 11, 2025

Uh oh!

daniel-lxs commented Aug 11, 2025

Uh oh!

roomote bot commented Aug 11, 2025

Uh oh!

roomote bot commented Aug 11, 2025

Uh oh!

daniel-lxs left a comment

Uh oh!

Uh oh!

	taskCommandExecuted: [
	\t[RooCodeEventName.TaskCommandExecuted]: [

feat: add taskCommandExecuted event to track command execution results #6375

feat: add taskCommandExecuted event to track command execution results #6375

Uh oh!

Conversation

roomote bot commented Jul 29, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Event Definition

Event Payload

Event Emission

Testing

Use Case

Implementation Details

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Critical Issues (Must Fix)

Important Suggestions (Should Consider)

Minor Improvements (Nice to Have)

Overall Assessment

Uh oh!

ellipsis-dev bot Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

daniel-lxs commented Aug 5, 2025

Uh oh!

roomote bot commented Aug 5, 2025

Uh oh!

roomote bot commented Aug 5, 2025

Uh oh!

daniel-lxs commented Aug 11, 2025

Uh oh!

roomote bot commented Aug 11, 2025

Uh oh!

ellipsis-dev bot Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot commented Aug 11, 2025

Issues Resolved:

Changes Made:

CI Status:

Uh oh!

daniel-lxs commented Aug 11, 2025

Uh oh!

roomote bot commented Aug 11, 2025

Uh oh!

roomote bot commented Aug 11, 2025

Changes Made:

1. ✅ Refactored repeated event emissions (Ellipsis comment #1)

2. ✅ Added TaskCommandExecuted to RooCodeEventName enum (Ellipsis comment #2)

3. ✅ Used enum reference instead of string literal (Ellipsis comment #3)

CI Status:

Uh oh!

daniel-lxs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roomote bot commented Jul 29, 2025 •

edited by ellipsis-dev bot

Loading