fix: use askApproval wrapper in insert_content and search_and_replace tools (RooCodeInc#7649)

roomote[bot] · roomote-agent · mtone · commit fd45dd06f54b · 2025-09-06T22:47:28.000-04:00
Fixes issue where isWriteProtected was incorrectly passed as the partial flag to task.ask(), causing "Current ask promise was ignored (RooCodeInc#1)" error. Both tools now use the askApproval wrapper function which correctly handles the parameter ordering, passing undefined for progressStatus and isWriteProtected as the fourth parameter. Fixes RooCodeInc#7648 Co-authored-by: Roo Code <roomote@roocode.com>
diff --git a/src/core/tools/insertContentTool.ts b/src/core/tools/insertContentTool.ts
@@ -153,9 +153,7 @@ export async function insertContentTool(
 		}
 
 		// Ask for approval (same for both flows)
-		const didApprove = await cline
-			.ask("tool", completeMessage, isWriteProtected)
-			.then((response) => response.response === "yesButtonClicked")
+		const didApprove = await askApproval("tool", completeMessage, undefined, isWriteProtected)
 
 		if (!didApprove) {
 			// Revert changes if diff view was shown
diff --git a/src/core/tools/searchAndReplaceTool.ts b/src/core/tools/searchAndReplaceTool.ts
@@ -224,9 +224,7 @@ export async function searchAndReplaceTool(
 			cline.diffViewProvider.scrollToFirstDiff()
 		}
 
-		const didApprove = await cline
-			.ask("tool", completeMessage, isWriteProtected)
-			.then((response) => response.response === "yesButtonClicked")
+		const didApprove = await askApproval("tool", completeMessage, undefined, isWriteProtected)
 
 		if (!didApprove) {
 			// Revert changes if diff view was shown

Original file line number	Diff line number	Diff line change
`@@ -153,9 +153,7 @@ export async function insertContentTool(`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`// Ask for approval (same for both flows)`
`156`		`- const didApprove = await cline`
`157`		`- .ask("tool", completeMessage, isWriteProtected)`
`158`		`- .then((response) => response.response === "yesButtonClicked")`
	`156`	`+ const didApprove = await askApproval("tool", completeMessage, undefined, isWriteProtected)`
`159`	`157`
`160`	`158`	`if (!didApprove) {`
`161`	`159`	`// Revert changes if diff view was shown`
Original file line number	Diff line number	Diff line change
`@@ -224,9 +224,7 @@ export async function searchAndReplaceTool(`
`224`	`224`	`cline.diffViewProvider.scrollToFirstDiff()`
`225`	`225`	`}`
`226`	`226`
`227`		`- const didApprove = await cline`
`228`		`- .ask("tool", completeMessage, isWriteProtected)`
`229`		`- .then((response) => response.response === "yesButtonClicked")`
	`227`	`+ const didApprove = await askApproval("tool", completeMessage, undefined, isWriteProtected)`
`230`	`228`
`231`	`229`	`if (!didApprove) {`
`232`	`230`	`// Revert changes if diff view was shown`