-
Notifications
You must be signed in to change notification settings - Fork 729
Filters refactor #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Filters refactor #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gasper Grom <[email protected]>
joanagmaia
approved these changes
Jun 13, 2023
frontend/src/modules/member/config/filters/activityType/ActivityTypeFilter.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 3dbe8e6
This pull request adds TypeScript support and linting rules to the frontend project, updates the Vue framework and some dependencies, optimizes the Cypress tests and the Docker files, refactors the activity list component and the activity service, and adds custom filter components and configuration for the activity type, channel, and date filters. These changes aim to improve the performance, reliability, and user interface of the frontend codebase and the activity feature.
🤖 Generated by Copilot at 3dbe8e6
Why
How
🤖 Generated by Copilot at 3dbe8e6
TagRepository
class (link)scss
files (link,link,link,link,link,link)ActivityService
class to send a POST request to the activity query endpoint (link)activity-list
component to use theCrFilter
component and theactivityStore
object for fetching and displaying the activities (link,link,link,link,link)activity-routes
file (link,link)cypress.config.js
file to reduce the memory usage and improve the performance of the tests (link,link)Checklist ✅
Feature
,Improvement
, orBug
.