Skip to content

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented May 16, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 8ff6566

This pull request improves the filter functionality and appearance for the activity and member modules. It uses a shared utility function for parsing the query parameters and defines custom apiFilterRenderer functions for each filter to handle the API request logic. It also removes the <b> tags from the filter labels and adds a search filter for members. Additionally, it updates the style of the dropdown component to increase the contrast and usability.

🤖 Generated by Copilot at 8ff6566

We're changing the filter configs, me hearties, yo ho ho
We're using apiFilterRenderer for the API, yo ho ho
We're removing the <b> tags from the labels, yo ho ho
We're heaving away on the count of three, yo ho ho

Why

How

🤖 Generated by Copilot at 8ff6566

  • Add text-gray-900 and cursor-default classes to selected or focused dropdown items in dropdown.scss (link)
  • Import queryUrlParserByType utility function from shared filters module and use it for parsing query parameters for select and multiselect filter types in activity and member filter configs (link, link, link)
  • Add apiFilterRenderer property to activity and member filter configs to define the logic for rendering filter value for API request, and replace queryRenderer property where applicable (link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Add memberSearchFilter config to main.ts to define the placeholder and the apiFilterRenderer function for the search filter, which returns an array of filter conditions that match the search value with the member's display name or email (link, link)
  • Remove <b> tags from itemLabelRenderer functions in member filter configs to make the label consistent with other filters (link, link, link, link, link, link, link, link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Improvement Created by Linear-GitHub Sync label May 16, 2023
@gaspergrom gaspergrom requested a review from joanagmaia May 16, 2023 13:23
@gaspergrom gaspergrom self-assigned this May 16, 2023
@gaspergrom gaspergrom merged commit 74a28c9 into feature/filters May 17, 2023
@gaspergrom gaspergrom deleted the improvement/filter-relation branch May 17, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants