Skip to content

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented May 24, 2023

Changes proposed ✍️

image

What

🤖 Generated by Copilot at bf1e4d3

Implemented and modified various filter components and configurations to enable boolean filtering of members and fix bugs in date and enrichment filters. Added new partial components and props to support the boolean filter feature and improve the user interface. Changed the filter logic and label rendering for the enrichedMember, joinedDate, and lastActivityDate filters.

🤖 Generated by Copilot at bf1e4d3

We've fixed the filters for the date and the bool
We've passed the config prop to every tool
We've added new components to make it look cool
So heave away, me hearties, heave away

Why

How

🤖 Generated by Copilot at bf1e4d3

  • Implemented a new boolean filter component and its related functions to allow users to filter members by boolean properties (link, link, link, link, link)
  • Fixed a bug where the enrichedMember filter would not work as expected for members who have never been enriched or have been enriched more than once, by using a different logic for filtering and rendering the filter value (link, link)
  • Corrected a mistake where the wrong filter type was used for the joinedDate and lastActivityDate filters, which would cause incorrect rendering and filtering of members by their date properties, by using the FilterConfigType.DATE instead of the FilterConfigType.BOOLEAN (link, link)
  • Modified the FilterItem.vue component to pass an additional prop called config to the dynamic component that renders the filter value, which allows the filter components to access the filter configuration object (link)
  • Modified the filter components to accept the config prop and use it to access the label and other options for the filter (link, link, link, link, link, link)
  • Added the missing type definition for the select filter configuration object, which is used as a prop for the SelectFilter.vue component (link)
  • Removed the unused import of apiFilterRendererByType from ./frontend/src/modules/member/config/filters/enrichedMember/config.ts, which improves the code readability and avoids unnecessary dependencies (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Feature Created by Linear-GitHub Sync label May 24, 2023
@gaspergrom gaspergrom requested a review from joanagmaia May 24, 2023 08:36
@gaspergrom gaspergrom self-assigned this May 24, 2023
@joanagmaia joanagmaia merged commit 2f2184e into feature/filters May 24, 2023
@joanagmaia joanagmaia deleted the feature/boolean-base branch May 24, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants