Fix missing init metadata #1251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1251 +/- ##
==========================================
- Coverage 86.10% 86.09% -0.01%
==========================================
Files 196 196
Lines 19647 19665 +18
Branches 2305 2308 +3
==========================================
+ Hits 16917 16931 +14
- Misses 2171 2173 +2
- Partials 559 561 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
meshula
reviewed
Mar 24, 2022
… install pure Python modules/files/packages
meshula
approved these changes
Mar 27, 2022
|
Thanks for the fix! |
|
It's a pleasure :) |
andrewmoore-nz
added a commit
to thecargocultnz/OpenTimelineIO
that referenced
this pull request
Apr 5, 2022
* main: Add Python 3.10 to CI (AcademySoftwareFoundation#1256) Fix missing init metadata (AcademySoftwareFoundation#1251) Support OTIO_PLUGIN_MANIFEST_PATH being set to an emptry string (AcademySoftwareFoundation#1253) Add ALE adapter argument `ale_name_column_key` (AcademySoftwareFoundation#1248) AAF Adapter: Mob transcription heuristics (AcademySoftwareFoundation#1249) Bump src/deps/Imath from `bd6f74c` to `bd254da` (AcademySoftwareFoundation#1245) clang notices that constexpr can't be used on a mutating function (AcademySoftwareFoundation#1242)
jminor
pushed a commit
that referenced
this pull request
May 2, 2022
* fix a regression where the dunder attributes weren't being preprended to __init__.py. * Don't install Python files from cmake if building with setuptools * Don't build C++ tests if building from setuptools * Add new OTIO_INSTALL_PYTHON_MODULES CMake variable to control when to install pure Python modules/files/packages Co-authored-by: Nick Porcino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1250
#1238 introduced a regression where it overwrote Python modules where modified by setuptools.
This PR disables copying python files from CMake if
OTIO_PYTHON_INSTALL_DIRis not set. AFAIK,OTIO_PYTHON_INSTALL_DIRis only used when running from setuptools. Or I think.I've also set
BUILD_TESTINGto OFF when building from setuptools since there is no point of building the C++ tests when building the Python extension.