Install full OTIO Python env with CMake #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Dolan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1238 +/- ##
=======================================
Coverage 86.15% 86.15%
=======================================
Files 196 196
Lines 19624 19624
Branches 2302 2302
=======================================
Hits 16907 16907
Misses 2159 2159
Partials 558 558
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
meshula
reviewed
Mar 11, 2022
meshula
approved these changes
Mar 12, 2022
This was referenced Mar 23, 2022
jminor
pushed a commit
that referenced
this pull request
May 2, 2022
Signed-off-by: Michael Dolan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when setting
OTIO_PYTHON_INSTALL=ONin CMake, only the compiled Python bindings are installed, which can't be used on their own. This update expands this to match the OTIO PyPI package in the CMake install location, including the three pure-python libs:opentimelineio,opentimelineview, andopentielineio_contrib. The result is that the CMake install is production-ready in a Python env.While on by default when building the Python bindings,
opentimelineviewis also gated behind the existing (and currently unused)OTIO_INSTALL_COMMANDLINE_TOOLS, andopentielineio_contribbehind a newOTIO_INSTALL_CONTRIBoption, so both can be turned off if only the core lib is needed.