Fix missing init metadata (#1251)

* fix a regression where the dunder attributes weren't being preprended to __init__.py.

* Don't install Python files from cmake if building with setuptools

* Don't build C++ tests if building from setuptools

* Add new OTIO_INSTALL_PYTHON_MODULES CMake variable to control when to install pure Python modules/files/packages

Co-authored-by: Nick Porcino <[email protected]>

Author: JeanChristopheMorinPerso

CMakeLists.txt

@@ -28,6 +28,7 @@ project(OpenTimelineIO VERSION ${OTIO_VERSION} LANGUAGES C CXX)
 option(OTIO_CXX_INSTALL               "Install the C++ bindings" ON)
 option(OTIO_PYTHON_INSTALL            "Install the Python bindings" OFF)
 option(OTIO_DEPENDENCIES_INSTALL      "Install OTIO's C++ header dependencies (any and nonstd)" ON)
+option(OTIO_INSTALL_PYTHON_MODULES    "Install OTIO pure Python modules/files" ON)
 option(OTIO_INSTALL_COMMANDLINE_TOOLS "Install the OTIO command line tools" ON)
 option(OTIO_INSTALL_CONTRIB           "Install the opentimelineio_contrib Python package" ON)
 set(OTIO_PYTHON_INSTALL_DIR "" CACHE STRING "Python installation dir (such as the site-packages dir)")
@@ -75,7 +76,7 @@ if(OTIO_PYTHON_INSTALL)
         message(STATUS "OTIO Defaulting Python install to ${OTIO_RESOLVED_PYTHON_INSTALL_DIR}")
     else()
         # either python_install or install_prefix have been set
-        if(OTIO_PYTHON_INSTALL_DIR_INITIALIZED_TO_DEFAULT)
+        if(NOT OTIO_PYTHON_INSTALL_DIR)
             # CMAKE_INSTALL_PREFIX was set, so install the python components there
             set(OTIO_RESOLVED_PYTHON_INSTALL_DIR "${CMAKE_INSTALL_PREFIX}/python")
 

setup.py

@@ -91,6 +91,10 @@ def generate_cmake_arguments(self):
             '-DOTIO_SHARED_LIBS:BOOL=OFF',
             '-DCMAKE_BUILD_TYPE=' + self.build_config,
             '-DOTIO_PYTHON_INSTALL_DIR=' + install_dir,
+            # turn off the C++ tests during a Python build
+            '-DBUILD_TESTING:BOOL=OFF',
+            # Python modules wil be installed by setuptools.
+            '-DOTIO_INSTALL_PYTHON_MODULES:BOOL=OFF',
         ]
 
         if platform.system() == "Windows":

src/py-opentimelineio/CMakeLists.txt

@@ -4,18 +4,20 @@
 add_subdirectory(opentime-bindings)
 add_subdirectory(opentimelineio-bindings)
 
-# Install pure-python OTIO packages to match PyPI wheel structure
-install(DIRECTORY "${PROJECT_SOURCE_DIR}/src/py-opentimelineio/opentimelineio/"
-    DESTINATION "${OTIO_RESOLVED_PYTHON_INSTALL_DIR}/opentimelineio")
+if(OTIO_INSTALL_PYTHON_MODULES)
+    # Install pure-python OTIO packages to match PyPI wheel structure
+    install(DIRECTORY "${PROJECT_SOURCE_DIR}/src/py-opentimelineio/opentimelineio/"
+        DESTINATION "${OTIO_RESOLVED_PYTHON_INSTALL_DIR}/opentimelineio")
 
-if(OTIO_INSTALL_COMMANDLINE_TOOLS)
-    install(DIRECTORY "${PROJECT_SOURCE_DIR}/src/opentimelineview"
-        DESTINATION "${OTIO_RESOLVED_PYTHON_INSTALL_DIR}")
-endif()
+    if(OTIO_INSTALL_COMMANDLINE_TOOLS)
+        install(DIRECTORY "${PROJECT_SOURCE_DIR}/src/opentimelineview"
+            DESTINATION "${OTIO_RESOLVED_PYTHON_INSTALL_DIR}")
+    endif()
 
-if(OTIO_INSTALL_CONTRIB)
-    install(DIRECTORY "${PROJECT_SOURCE_DIR}/contrib/opentimelineio_contrib"
-        DESTINATION "${OTIO_RESOLVED_PYTHON_INSTALL_DIR}"
-        PATTERN "tests" EXCLUDE
-        PATTERN "Makefile" EXCLUDE)
+    if(OTIO_INSTALL_CONTRIB)
+        install(DIRECTORY "${PROJECT_SOURCE_DIR}/contrib/opentimelineio_contrib"
+            DESTINATION "${OTIO_RESOLVED_PYTHON_INSTALL_DIR}"
+            PATTERN "tests" EXCLUDE
+            PATTERN "Makefile" EXCLUDE)
+    endif()
 endif()