Skip to content

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Nov 20, 2022

Fixes: #1290

Related: https://no-color.org/

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example:
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@ssbarnea ssbarnea added the bug:minor does not affect many people or has no big impact label Nov 20, 2022
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test 👍

@gaborbernat
Copy link
Member

Also a changelog entry please.

@ssbarnea ssbarnea force-pushed the v4/term-dumb branch 2 times, most recently from 9d5bcff to 879a6c0 Compare November 21, 2022 00:06
@gaborbernat gaborbernat marked this pull request as ready for review November 21, 2022 01:28
@gaborbernat
Copy link
Member

You'll need to pass the CI here 😂

@ssbarnea ssbarnea added this to the 4.0 milestone Nov 21, 2022
@gaborbernat gaborbernat merged commit 991ac4d into tox-dev:rewrite Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided bug:minor does not affect many people or has no big impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants