Fixed logic

Author: ssbarnea

src/tox/config/cli/parser.py

@@ -290,10 +290,10 @@ def add_color_flags(parser: ArgumentParser) -> None:
     converter = StrConvert()
     if converter.to_bool(os.environ.get("NO_COLOR", "")):
         color = "no"
-    elif os.environ.get("TERM", "") == "dumb":
-        color = "no"
     elif converter.to_bool(os.environ.get("FORCE_COLOR", "")):
         color = "yes"
+    elif os.environ.get("TERM", "") == "dumb":
+        color = "no"
     else:
         color = "yes" if sys.stdout.isatty() else "no"
 

tests/config/cli/test_parser.py

@@ -54,14 +54,14 @@ def test_parser_color(
     stdout_mock = mocker.patch("tox.config.cli.parser.sys.stdout")
     stdout_mock.isatty.return_value = is_atty
 
-    if term == "dumb":
-        expected = False
-    elif tox_color in ("yes", "no"):
+    if tox_color in ("yes", "no"):
         expected = tox_color == "yes"
     elif no_color == "1":
         expected = False
     elif force_color == "1":
         expected = True
+    elif term == "dumb":
+        expected = False
     else:
         expected = is_atty