Skip to content

Chore: update git pages action #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2025
Merged

Chore: update git pages action #2375

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95aa300
fix: revert @web3-onboard/para in docs to 1.0.0
arcoraven Jul 22, 2025
b55af6f
chore: update git pages
arcoraven Jul 23, 2025
7e04e54
Merge remote-tracking branch 'origin/develop' into ph/git-pages
arcoraven Jul 23, 2025
2bf77c7
remove auto trigger
arcoraven Jul 23, 2025
3929ae0
rename blocknative URLs to thirdweb
arcoraven Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
name: Deploy documentation to Pages

on:
# Runs on pushes targeting the default branch
push:
branches: ["docs"]

# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:

Expand All @@ -32,13 +28,13 @@ jobs:
working-directory: ./docs
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683

- name: Setup Pages
uses: actions/configure-pages@v2
uses: actions/configure-pages@983d7736d9b0ae728b81ab479565c72886d7745b

- name: Setup Nodejs and yarn
uses: actions/setup-node@v2
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020
with:
node-version: "18.18"
cache: yarn
Expand All @@ -52,21 +48,21 @@ jobs:
run: yarn build

- name: Generate the sitemap
uses: cicirello/generate-sitemap@v1
uses: cicirello/generate-sitemap@f76c8312a5a364c49e2610b8af12ae861805a056
with:
path-to-root: './docs/build'
drop-html-extension: true
base-url-path: https://onboard.blocknative.com
base-url-path: https://web3onboard.thirdweb.com

Comment on lines 50 to 56
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

base-url-path may be an invalid input name for cicirello/generate-sitemap

According to the action’s docs the expected input is base-url, not base-url-path. Passing an unknown input is silently ignored and will leave the generated sitemap with the default base (http://example.com). Double-check the README and adjust if necessary.

🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 56-56: trailing spaces

(trailing-spaces)

🤖 Prompt for AI Agents 
In .github/workflows/docs.yml around lines 50 to 56, the input name
`base-url-path` used for the cicirello/generate-sitemap action is incorrect and
should be `base-url`. Update the input key from `base-url-path` to `base-url` to
ensure the sitemap is generated with the correct base URL instead of the
default.

- name: Peak at folder contents
run: ls -al

- name: Upload artifact
uses: actions/upload-pages-artifact@v1
uses: actions/upload-pages-artifact@56afc609e74202658d3ffba0e8f6dda462b719fa
with:
# Upload entire repository
path: './docs/build'

- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v1
uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e