Skip to content

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Jul 23, 2025

Summary by CodeRabbit

  • Chores
    • Workflow for documentation updates now runs only when manually triggered, not on every push to the "docs" branch.
    • Updated GitHub Actions to use specific commit SHAs for improved reliability.
    • Changed sitemap base URL to "https://web3onboard.thirdweb.com".
    • Updated all documentation and example URLs from "onboard.blocknative.com" to "web3onboard.thirdweb.com" to reflect rebranding and updated hosting.

Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ❌ Failed (Inspect) Jul 23, 2025 5:42am

Copy link

coderabbitai bot commented Jul 23, 2025

Walkthrough

The repository-wide URLs referencing "onboard.blocknative.com" were updated to "web3onboard.thirdweb.com" across documentation, configuration files, package metadata, and example projects. The GitHub Actions workflow for docs was changed to manual triggering with action versions pinned to commit SHAs. No public API or logic changes were introduced.

Changes

File(s) Change Summary
.github/workflows/docs.yml Workflow trigger changed to manual; Actions updated to commit SHAs; sitemap base URL updated.
README.md, examples//README.md, docs/src/routes/docs//+page.md, docs/src/routes/faq/+page.md, packages//README.md, packages//package.json, examples/**/pages/index.* URLs updated from "onboard.blocknative.com" to "web3onboard.thirdweb.com" in documentation links, homepage fields, and anchor tags.
docs/src/lib/components/SEO/index.svelte, docs/src/lib/services/onboard.js, docs/src/routes/+layout.svelte, packages/demo/src/App.svelte, examples/with-vite-react/src/App.tsx, examples/with-vite-react/src/web3-onboard.ts URLs updated from "onboard.blocknative.com" to "web3onboard.thirdweb.com" in configuration, metadata, and initialization code.
packages/bloom/src/index.ts, packages/walletconnect/src/index.ts Error message URLs updated to new domain.
examples/with-sveltekit/svelte.config.js, examples/with-sveltekit/vite.config.ts Comment URLs updated to new domain.

Estimated code review effort

1 (~5 minutes)

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/docs.yml (1)

32-35: Strip trailing whitespace to satisfy YAML lint and keep diffs clean

The linter flagged trailing spaces on the highlighted lines. Removing them avoids CI noise and keeps version-control diffs minimal.

-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683␠
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@
-        uses: actions/configure-pages@983d7736d9b0ae728b81ab479565c72886d7745b␠
+        uses: actions/configure-pages@983d7736d9b0ae728b81ab479565c72886d7745b
@@
-          base-url-path: https://web3onboard.thirdweb.com␠
+          base-url-path: https://web3onboard.thirdweb.com
@@
-        run: ls -al␠
+        run: ls -al
@@
-          path: './docs/build'␠
+          path: './docs/build'

Also applies to: 56-59, 65-65

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdc77c6 and 2bf77c7.

📒 Files selected for processing (1)
  • .github/workflows/docs.yml (2 hunks)
🪛 YAMLlint (1.37.1)
.github/workflows/docs.yml

[error] 32-32: trailing spaces

(trailing-spaces)


[error] 35-35: trailing spaces

(trailing-spaces)


[error] 56-56: trailing spaces

(trailing-spaces)


[error] 59-59: trailing spaces

(trailing-spaces)


[error] 65-65: trailing spaces

(trailing-spaces)

🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/docs.yml

[error] 32-32: trailing spaces

(trailing-spaces)


[error] 35-35: trailing spaces

(trailing-spaces)


[error] 56-56: trailing spaces

(trailing-spaces)


[error] 59-59: trailing spaces

(trailing-spaces)


[error] 65-65: trailing spaces

(trailing-spaces)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Checks
🔇 Additional comments (2)
.github/workflows/docs.yml (2)

31-38: Good move — actions pinned to immutable SHAs, but remember to keep them fresh

Pinning prevents supply-chain attacks, but it also freezes you on that exact commit forever. Make sure you have either Dependabot or an internal process that periodically bumps these SHAs (especially for actions/checkout, setup-node, etc.) so you still receive upstream security fixes.


4-8: Manual-only trigger: confirm this matches the release cadence

Removing the push trigger means docs won’t auto-publish when the docs branch updates. If that’s intentional (e.g., to gate releases), ignore; otherwise consider keeping both push and workflow_dispatch so the job can still be run ad-hoc.

Comment on lines 50 to 56
- name: Generate the sitemap
uses: cicirello/generate-sitemap@v1
uses: cicirello/generate-sitemap@f76c8312a5a364c49e2610b8af12ae861805a056
with:
path-to-root: './docs/build'
drop-html-extension: true
base-url-path: https://onboard.blocknative.com
base-url-path: https://web3onboard.thirdweb.com

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

base-url-path may be an invalid input name for cicirello/generate-sitemap

According to the action’s docs the expected input is base-url, not base-url-path. Passing an unknown input is silently ignored and will leave the generated sitemap with the default base (http://example.com). Double-check the README and adjust if necessary.

🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 56-56: trailing spaces

(trailing-spaces)

🤖 Prompt for AI Agents
In .github/workflows/docs.yml around lines 50 to 56, the input name
`base-url-path` used for the cicirello/generate-sitemap action is incorrect and
should be `base-url`. Update the input key from `base-url-path` to `base-url` to
ensure the sitemap is generated with the correct base URL instead of the
default.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
examples/with-vanilla-js/README.md (1)

33-33: Fix typo in documentation sentence

“integraions” → “integrations”. Small spelling fix keeps the docs polished and professional.

-To learn more about other web3Onboard integraions, take a look at our documentation: [Web3Onboard Documentation](https://web3onboard.thirdweb.com/docs/overview/introduction#features) for more details.
+To learn more about other web3Onboard integrations, take a look at our documentation: [Web3Onboard Documentation](https://web3onboard.thirdweb.com/docs/overview/introduction#features) for more details.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2bf77c7 and 3929ae0.

📒 Files selected for processing (73)
  • README.md (1 hunks)
  • docs/src/lib/components/SEO/index.svelte (1 hunks)
  • docs/src/lib/services/onboard.js (3 hunks)
  • docs/src/routes/+layout.svelte (1 hunks)
  • docs/src/routes/docs/[...3]modules/[...8]wagmi/+page.md (1 hunks)
  • docs/src/routes/docs/[...4]wallets/[...1]arcana/+page.md (1 hunks)
  • docs/src/routes/docs/[...4]wallets/[...23]phantom/+page.md (1 hunks)
  • docs/src/routes/faq/+page.md (1 hunks)
  • examples/with-ledger/README.md (1 hunks)
  • examples/with-nextjs-13/pages/index.tsx (1 hunks)
  • examples/with-nextjs/pages/index.js (1 hunks)
  • examples/with-sveltekit/README.md (1 hunks)
  • examples/with-sveltekit/svelte.config.js (1 hunks)
  • examples/with-sveltekit/vite.config.ts (1 hunks)
  • examples/with-vanilla-js/README.md (1 hunks)
  • examples/with-vite-react/src/App.tsx (1 hunks)
  • examples/with-vite-react/src/web3-onboard.ts (1 hunks)
  • package.json (1 hunks)
  • packages/arcana-auth/README.md (1 hunks)
  • packages/blocto/README.md (1 hunks)
  • packages/blocto/package.json (1 hunks)
  • packages/bloom/package.json (1 hunks)
  • packages/bloom/src/index.ts (1 hunks)
  • packages/cede-store/package.json (1 hunks)
  • packages/coinbase/package.json (1 hunks)
  • packages/common/package.json (1 hunks)
  • packages/core/README.md (1 hunks)
  • packages/core/package.json (1 hunks)
  • packages/dcent/package.json (1 hunks)
  • packages/demo/src/App.svelte (3 hunks)
  • packages/finoaconnect/package.json (1 hunks)
  • packages/fortmatic/package.json (1 hunks)
  • packages/frame/package.json (1 hunks)
  • packages/gas/README.md (1 hunks)
  • packages/gas/package.json (1 hunks)
  • packages/gnosis/package.json (1 hunks)
  • packages/hw-common/package.json (1 hunks)
  • packages/injected/package.json (1 hunks)
  • packages/keepkey/package.json (1 hunks)
  • packages/keystone/package.json (1 hunks)
  • packages/ledger/package.json (1 hunks)
  • packages/magic/package.json (1 hunks)
  • packages/metamask/package.json (1 hunks)
  • packages/mew/package.json (1 hunks)
  • packages/para/package.json (1 hunks)
  • packages/particle-network/package.json (1 hunks)
  • packages/passport/package.json (1 hunks)
  • packages/phantom/README.md (1 hunks)
  • packages/phantom/package.json (1 hunks)
  • packages/portis/package.json (1 hunks)
  • packages/react/README.md (1 hunks)
  • packages/react/package.json (1 hunks)
  • packages/sequence/package.json (1 hunks)
  • packages/solid/README.md (1 hunks)
  • packages/solid/package.json (1 hunks)
  • packages/taho/package.json (1 hunks)
  • packages/tallyho/package.json (1 hunks)
  • packages/torus/package.json (1 hunks)
  • packages/transaction-preview/package.json (1 hunks)
  • packages/trezor/package.json (1 hunks)
  • packages/uauth/package.json (1 hunks)
  • packages/unstoppable-resolution/package.json (1 hunks)
  • packages/venly/package.json (1 hunks)
  • packages/vue/README.md (1 hunks)
  • packages/vue/package.json (1 hunks)
  • packages/wagmi/README.md (1 hunks)
  • packages/wagmi/package.json (1 hunks)
  • packages/walletconnect/package.json (1 hunks)
  • packages/walletconnect/src/index.ts (1 hunks)
  • packages/walletlink/package.json (1 hunks)
  • packages/web3auth/package.json (1 hunks)
  • packages/xdefi/package.json (1 hunks)
  • packages/zeal/package.json (1 hunks)
🪛 LanguageTool
examples/with-vanilla-js/README.md

[grammar] ~33-~33: Ensure spelling is correct
Context: ...# Learn More To learn more about other web3Onboard integraions, take a look at our documentation: [Web...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

✅ Files skipped from review due to trivial changes (72)
  • examples/with-nextjs-13/pages/index.tsx
  • docs/src/routes/docs/[...4]wallets/[...23]phantom/+page.md
  • README.md
  • examples/with-vite-react/src/App.tsx
  • packages/bloom/package.json
  • packages/vue/README.md
  • packages/wagmi/package.json
  • packages/blocto/package.json
  • packages/core/package.json
  • packages/arcana-auth/README.md
  • packages/sequence/package.json
  • packages/wagmi/README.md
  • packages/coinbase/package.json
  • docs/src/routes/faq/+page.md
  • examples/with-ledger/README.md
  • docs/src/routes/docs/[...3]modules/[...8]wagmi/+page.md
  • packages/phantom/README.md
  • docs/src/routes/+layout.svelte
  • packages/core/README.md
  • packages/vue/package.json
  • packages/mew/package.json
  • packages/tallyho/package.json
  • packages/solid/README.md
  • examples/with-sveltekit/svelte.config.js
  • packages/portis/package.json
  • packages/keystone/package.json
  • packages/walletlink/package.json
  • packages/uauth/package.json
  • packages/taho/package.json
  • packages/passport/package.json
  • packages/solid/package.json
  • package.json
  • examples/with-sveltekit/README.md
  • packages/torus/package.json
  • packages/injected/package.json
  • packages/cede-store/package.json
  • packages/walletconnect/package.json
  • packages/dcent/package.json
  • docs/src/lib/components/SEO/index.svelte
  • packages/finoaconnect/package.json
  • packages/react/README.md
  • docs/src/routes/docs/[...4]wallets/[...1]arcana/+page.md
  • packages/gnosis/package.json
  • examples/with-vite-react/src/web3-onboard.ts
  • packages/gas/package.json
  • packages/ledger/package.json
  • packages/metamask/package.json
  • examples/with-nextjs/pages/index.js
  • packages/particle-network/package.json
  • packages/frame/package.json
  • packages/venly/package.json
  • packages/unstoppable-resolution/package.json
  • packages/xdefi/package.json
  • packages/gas/README.md
  • packages/walletconnect/src/index.ts
  • packages/fortmatic/package.json
  • packages/blocto/README.md
  • packages/hw-common/package.json
  • packages/react/package.json
  • packages/bloom/src/index.ts
  • packages/magic/package.json
  • packages/transaction-preview/package.json
  • packages/zeal/package.json
  • packages/phantom/package.json
  • packages/trezor/package.json
  • packages/keepkey/package.json
  • examples/with-sveltekit/vite.config.ts
  • packages/web3auth/package.json
  • packages/para/package.json
  • packages/common/package.json
  • packages/demo/src/App.svelte
  • docs/src/lib/services/onboard.js
🧰 Additional context used
🪛 LanguageTool
examples/with-vanilla-js/README.md

[grammar] ~33-~33: Ensure spelling is correct
Context: ...# Learn More To learn more about other web3Onboard integraions, take a look at our documentation: [Web...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Socket Security: Pull Request Alerts
  • GitHub Check: Checks

@arcoraven arcoraven merged commit a344864 into develop Jul 23, 2025
5 of 6 checks passed
@arcoraven arcoraven deleted the ph/git-pages branch July 23, 2025 04:29
arcoraven added a commit that referenced this pull request Jul 23, 2025
* fix: keystone dep breaks yarn 4 installation

If you try to use web3-onboard with yarn v4 (although I think the
problem will be there with yarn v2 and v3) it fails with:
YN0001: │ Error: @keystonehq/eth-keyring@^0.14.00.3 isn't supported by
any available resolver

First install is ok, but if you run the install again you’ll get the
above. 0.14.00.3 is apparently not a valid range and the only way to
get this fixed is to fix the dependency. Yarn v1 resolves
0.14.00.3 to 0.14.4 and that is the version I’ve set here.

* feature: thirdweb branding

* fix: powered by thirdweb link

* release: bump versions

* chore: bump metamask to 0.32.0

* patch cbwsdk

* update versions

* update keystone package

* lock

* update node version in CI

* bump node version for keystone ci job

* Bump @trezor/connect-web to version 9.5.0

* bump node version for CI

* github actions too

* update brand

* icon update

* update version

* update version

* update wagmi for para

* post rebase

* feat: add link to thirdweb logo

* Setting up GitHub CI for packages

* Pin github ci version

* update node version for all packages (#2367)

* update node version for all packages

* update

* Update CI (#2368)

* Setting up GitHub CI for packages

* Pin github ci version

* update node version for all packages (#2367)

* update node version for all packages

* update

---------

Co-authored-by: Jake Loo <[email protected]>

* chore: optimize onekey logo (#2369)

* fix: revert @web3-onboard/para in docs to 1.0.0 (#2372)

* fix: revert @web3-onboard/para in docs to 1.0.0

* add missing thirdweb icon

* Chore: update git pages action (#2375)

* fix: revert @web3-onboard/para in docs to 1.0.0

* chore: update git pages

* remove auto trigger

* rename blocknative URLs to thirdweb

---------

Co-authored-by: Daniel Dimitrov <[email protected]>
Co-authored-by: Adam Carpenter <[email protected]>
Co-authored-by: gregfromstl <[email protected]>
Co-authored-by: Tamas <[email protected]>
Co-authored-by: Jake Feldman <[email protected]>
Co-authored-by: Joaquim Verges <[email protected]>
Co-authored-by: Tomas Martykan <[email protected]>
Co-authored-by: Taylor Bosch <[email protected]>
Co-authored-by: Jake Loo <[email protected]>
Co-authored-by: ByteZhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant