🐛(frontend) fix dnd conflict with tree and Blocknote #1328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
fix/dnd-conflict
branch
from
a487782 to
9ca3fd7
Compare
Closed
|
Size Change: -43 B (0%) Total Size: 3.64 MB
|
PanchoutNathan
approved these changes
Sep 3, 2025
When we were dragging an item in the doc tree, the background color was opaque, making it difficult to see the underlying content. The cause was that we were overriding the transparent background color.
We have different DND system in the page, one on the menu tree and one in the Blocknote editor. The menu tree was adding a transparent layer when user were dragging element on the Blocknote editor, blocking the Blocknote DND. We update the ui-kit to add the prop dndRootElement, dndRootElement is now used to specify the root element for DND, this transparent layer is now only applied when a drag is made from the menu tree. It stabilize as well the drop position, making it easier to drop element.
Recent upgrade of ui-kit removed the z-index for the modal backdrop, causing it to be hidden behind other elements. This commit restores the z-index to ensure the modal backdrop is displayed correctly.
AntoLC
force-pushed
the
fix/dnd-conflict
branch
from
c56d6ce to
814eb1f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We have different DND system in the page, one on the menu tree and one in the Blocknote editor.
The menu tree was adding a transparent layer when user were dragging element on the Blocknote editor, blocking the Blocknote DND.
Proposal
We update the
ui-kitto add the propdndRootElement(suitenumerique/ui-kit#106),dndRootElementis now used to specify the root element for DND, this transparent layer is now only applied when a drag is made from the menu tree.It stabilize as well the drop position, making it easier to drop element.