Tokens::$functionNameTokens: include the parent
keyword
#3619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to PR #3546, which changed how the
parent
keyword in anew parent
snippet was tokenized fromT_STRING
toT_PARENT
.The
T_PARENT
keyword token, however, was not included in theTokens::$functionNameTokens
array, which was the underlying cause for the bug reported in #3618.Fixed now.
Tested by adding additional tests to the
Generic.WhiteSpace.ArbitraryParenthesesSpacing
sniff. These tests passed in PHPCS 3.6.2 and started failing in PHPCS 3.7.0. Once this fix has been merged, the tests will pass again.Fixes #3618