BCTokens::functionNameTokens(): sync with upstream #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream PR squizlabs/PHP_CodeSniffer 3546, which is included in PHPCS 3.7.0, changed the tokenization of the `parent` keyword in `new parent()` from `T_STRING` to `T_PARENT`. Follow-up PR squizlabs/PHP_CodeSniffer 3619, which is expected to be included in PHPCS 3.7.2, adds the `T_PARENT` token to the `Tokens::$functionNameTokens` array. This syncs the `BCTokens::functionNameTokens()` function with this upstream change.
jrfnl
deleted the
backcompat/bctokens-functionnametokens-sync-with-upsteam
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR squizlabs/PHP_CodeSniffer#3546, which is included in PHPCS 3.7.0, changed the tokenization of the
parentkeyword innew parent()fromT_STRINGtoT_PARENT.Follow-up PR squizlabs/PHP_CodeSniffer#3619, which is expected to be included in PHPCS 3.7.2, adds the
T_PARENTtoken to theTokens::$functionNameTokensarray.This syncs the
BCTokens::functionNameTokens()function with this upstream change.