Skip to content

Conversation

zdover23
Copy link
Contributor

@zdover23 zdover23 commented Sep 28, 2023

Reword the English in a the note that directs the reader to the Rocky ISO mirrors, so that the note reads better.

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@zdover23 zdover23 changed the title installation.md: improve grammar in a note in 8.6 install guide 8_6_installation.md: improve grammar in a note in 8.6 install guide Sep 28, 2023
@zdover23 zdover23 force-pushed the doc-2023-09-28-8_6_installation-note-grammar branch from 01e0ae1 to 1943b9c Compare September 28, 2023 04:12
@zdover23
Copy link
Contributor Author

see also #1503

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes take up three separate lines, which I don't think was your intent. Also, the formatting should include the 4 spaces indent so that it fits as part of the note. See https://docs.rockylinux.org/guides/contribute/rockydocs_formatting/#admonitions for admonition formatting. Let me know if you have questions.

Reword the English in a the note that directs the reader to the Rocky
ISO mirrors, so that the note reads better.

Signed-off-by: Zac Dover <[email protected]>
@zdover23 zdover23 force-pushed the doc-2023-09-28-8_6_installation-note-grammar branch from 1943b9c to d8976f3 Compare September 28, 2023 18:20
@github-actions
Copy link

Test results for d8976f3:

Number of broken URLs: 0

URL,RESULT,FILENAME

@zdover23
Copy link
Contributor Author

zdover23 commented Sep 28, 2023

These changes take up three separate lines, which I don't think was your intent. Also, the formatting should include the 4 spaces indent so that it fits as part of the note. See https://docs.rockylinux.org/guides/contribute/rockydocs_formatting/#admonitions for admonition formatting. Let me know if you have questions.

My intention was to wrap the admonition at 80 lines, but my desire to conform to local standards is stronger than any desire to indulge my own preferences.

I've put the body text of this admonition on a single line now. I thought that I had included the four-space indent. Anyway, I haven't changed anything with respect to the four-space indent.

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @zdover23

@sspencerwire sspencerwire merged commit f7da279 into rocky-linux:main Sep 29, 2023
@sspencerwire
Copy link
Contributor

@all-contributors add @zdover23 for content

@allcontributors
Copy link
Contributor

@sspencerwire

I've put up a pull request to add @zdover23! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants