Skip to content

Conversation

zdover23
Copy link
Contributor

@zdover23 zdover23 commented Sep 28, 2023

Reword the English in a the note that directs the reader to the Rocky ISO mirrors, so that the note reads better.

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • [ x] Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

Reword the English in a the note that directs the reader to the Rocky
ISO mirrors, so that the note reads better.

Signed-off-by: Zac Dover <[email protected]>
@zdover23
Copy link
Contributor Author

zdover23 commented Sep 28, 2023

see also #1504

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zdover23. It looks like this is now formatted on 3 separate lines, rather than on one line. I think that might be a problem, and probably wasn't your intent. Can you fix this before we merge? Also, admonitions need the 4 space indentation to stay within the note. Let me know if you have questions!

format t he note correctly
Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this one like the other one @zdover23 . Thank you again.

@sspencerwire sspencerwire merged commit 8f8a048 into rocky-linux:main Sep 29, 2023
@zdover23
Copy link
Contributor Author

I've fixed this one like the other one @zdover23 . Thank you again.

I'll make more PRs over the weekend. It's 11 PM down here right now. I have a list of Ceph dependencies Rocky Linux is missing. Is there a place I can usefully report that?

@github-actions
Copy link

Test results for 31b0667:

Number of broken URLs: 0

URL,RESULT,FILENAME

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants