Test 1 #1
Closed
Test 1 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clarify docs on invalid serviceName Fixes kubernetes-sigs#638 * update for comments * Wrap
…aders document multi-value headers as undefined
…tation Implementing and Documenting GEP 746 (TLS Updates)
Documenting Route attachment for v1alpha2
robscott
force-pushed
the
v1alpha2-review-base
branch
from
47910e1 to
3f57e95
Compare
* Fix kubernetes version support * Update site-src/v1alpha2/faq.md Co-authored-by: Rob Scott <[email protected]> * Update site-src/v1alpha2/faq.md Co-authored-by: Rob Scott <[email protected]> * format restrict each line less than 80 characters. * fix email address Co-authored-by: Rob Scott <[email protected]>
Signed-off-by: Nick Young <[email protected]>
Signed-off-by: Nick Young <[email protected]>
Signed-off-by: Nick Young <[email protected]>
Restructure docs and split into versioned and unversioned
…ce-routing update to our cross-namespace routing guide
Signed-off-by: Nick Young <[email protected]>
Migrate examples to versioned and fix some missing links
Versioning CRD yaml to simplify only installing v1alpha2
Tightening validation + adding basic validation tests
Fix tls-cert-cross-namespace group
Signed-off-by: Jintao Zhang <[email protected]>
Change HAProxy Ingress' external link to the latest branch - v0.13 which is the first controller version that implements Gateway API was already graduated to GA.
Fix typo `It's is`
Fix broken site links
Co-authored-by: Harry <[email protected]>
GEP 735 L4 Traffic Matching
Puts back controller-gen logic to generate the zz_generated.deepcopy.go file for v1alpha2 CRDs. Signed-off-by: Steve Sloka <[email protected]>
Signed-off-by: Steve Sloka <[email protected]>
Update version of golangci-lint as well as remove deprecated linters.
hack: fixup deepcopy-gen for CRDs
Also creating new docs page to mirror GEP content.
…lines Updating versioning guidelines to allow for bug fixes in patch releases
…-fix Fixing bug where namespace could be unspecified in ReferencePolicy
* Validating HTTPRouteFilter type consistency * fixing Makefile regression * relaxing validation constraints to simplify switch statement * adding default type validation * refactoring validateHTTPRouteSpec * fixing paths * adding HTTPRouteFilter URLRewrite validation * validating route filters are not empty * simplying validation with validateHTTPRouteFilters * removing reflect.DeepEqual as is not necessary * validate route filters are not nil * small fixes * fixing empty filter test
The HTTPRoute validation tests were directly calling internal API functions to try to pinpoint the set of tests that they expected to be run. This is a risky pattern, because there's nothing that ensures that the internal functions are actually wired up to the validation logic correctly. This change establishes a new pattern, where each test can set up fixtures in theor own way (for the sake of brevity), but the test is always driven by the top-level validation call. This exposed a number of bugs where the validation functions were not wired up correctly. In the future, this can be improved by updating the tests to supply specific expecations on the returned errors rather than just the error count. Signed-off-by: James Peach <[email protected]>
Add missing word in Introduction
…idation Fix HTTPRoute validation tests.
…card value and precise value for hostnames. Updates the HTTPRequestRedirectFilter.Hostname to use the new PreciseHostname type which validates the value cannot contain wildcard characters. Signed-off-by: Steve Sloka <[email protected]>
Signed-off-by: Steve Sloka <[email protected]>
Signed-off-by: Steve Sloka <[email protected]>
Fixing accidental escaping of namespace/name in docs
Introduce wildcardhostname field
robscott
added a commit
that referenced
this pull request
Sep 7, 2023
…Gateway to Backend...) Update with API details (kubernetes-sigs#2113) * GEP-1897 Update with API details * GEP-1897 Update with API details - suggested changes #1 * Update geps/gep-1897.md Co-authored-by: Rob Scott <[email protected]> * Update geps/gep-1897.md Co-authored-by: Rob Scott <[email protected]> * GEP-1897 Update with API details - suggested changes kubernetes-sigs#2 * GEP-1897 Update with API details - suggested changes kubernetes-sigs#3 * GEP-1897 Update with API details - suggested changes 4 * GEP-1897 Update with API details - suggested changes 5 * GEP-1897 Update with API details - suggested changes 7 * GEP-1897 Update with API details - suggested changes 8 * GEP-1897 Update with API details - suggested changes 9 * GEP-1897 Update with API details - suggested changes 10 * GEP-1897 Update with API details - suggested changes 11 --------- Co-authored-by: Rob Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing