Implementing and Documenting GEP 746 (TLS Updates) #768
Conversation
k8s-ci-robot
added
the
kind/feature
|
@robscott: GitHub didn't allow me to request PR reviews from the following users: Miciah, howardjohn. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
size/L
robscott
force-pushed
the
gep-746-implementation
branch
3 times, most recently
from
cf0a14d to
c283af9
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
robscott
force-pushed
the
gep-746-implementation
branch
from
c283af9 to
d21a3a6
Compare
k8s-ci-robot
removed
the
lgtm
robscott
force-pushed
the
gep-746-implementation
branch
from
d21a3a6 to
a6f1fa8
Compare
|
Thanks for the feedback @bowei! I think I've updated everything, PTAL. |
| tls: | ||
| certificateRef: | ||
| kind: Secret | ||
| group: "" |
There was a problem hiding this comment.
consider omitting group since the default is "core"
There was a problem hiding this comment.
I know we once had a default here, but it looks like we've removed it in favor of a generic ObjectRef, so I think this still needs to be specified.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpeach, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
What type of PR is this?
/kind feature
What this PR does / why we need it:
This implements and documents GEP #746.
Which issue(s) this PR fixes:
Fixes #746
Does this PR introduce a user-facing change?:
Note: The CRD verification will fail on this PR until #754 gets in.
Deploy Preview: https://deploy-preview-768--kubernetes-sigs-gateway-api.netlify.app/v1alpha2/guides/tls/
/cc @hbagdi @howardjohn @jpeach @Miciah @youngnick