feat: make metrics scraping optional #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svghadi
reviewed
May 14, 2024
saumeya
force-pushed
the
make-metrics-optional
branch
from
91d3b15 to
2a46272
Compare
|
/test v4.14-kuttl-parallel |
|
/test v4.13-kuttl-parallel |
|
/test v4.14-kuttl-parallel |
|
Thanks for reviewing @svghadi |
|
/test v4.14-kuttl-parallel |
|
/test v4.13-kuttl-parallel |
saumeya
force-pushed
the
make-metrics-optional
branch
2 times, most recently
from
b583b25 to
4979b5f
Compare
saumeya
force-pushed
the
make-metrics-optional
branch
from
4979b5f to
8332813
Compare
svghadi
reviewed
May 28, 2024
|
/test v4.14-kuttl-parallel |
|
/test v4.12-kuttl-parallel |
saumeya
force-pushed
the
make-metrics-optional
branch
from
0985283 to
bdfc4c4
Compare
|
/test v4.12-images |
|
/test v4.12-images |
|
/test v4.14-e2e |
|
/retest |
Signed-off-by: saumeya <[email protected]> fixes Signed-off-by: saumeya <[email protected]> fix tests and add monitoring by default Signed-off-by: saumeya <[email protected]> add test case Signed-off-by: saumeya <[email protected]> review comments Signed-off-by: saumeya <[email protected]> review comments Signed-off-by: saumeya <[email protected]> review comments Signed-off-by: saumeya <[email protected]> review comments Signed-off-by: saumeya <[email protected]> add e2e for the feature Signed-off-by: saumeya <[email protected]> uncommenting Signed-off-by: saumeya <[email protected]> rebase Signed-off-by: saumeya <[email protected]> changes: Signed-off-by: saumeya <[email protected]> changes Signed-off-by: saumeya <[email protected]>
Signed-off-by: saumeya <[email protected]>
Signed-off-by: saumeya <[email protected]>
Signed-off-by: saumeya <[email protected]>
Signed-off-by: saumeya <[email protected]>
Signed-off-by: saumeya <[email protected]>
Signed-off-by: saumeya <[email protected]>
saumeya
force-pushed
the
make-metrics-optional
branch
from
bdfc4c4 to
454d858
Compare
|
/lgtm |
|
/approve |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iam-veeramalla, saumeya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
trdoyle81
pushed a commit
to trdoyle81/gitops-operator
that referenced
this pull request
Aug 13, 2024
* feat: make metrics scraping optional Signed-off-by: saumeya <[email protected]> fixes Signed-off-by: saumeya <[email protected]> fix tests and add monitoring by default Signed-off-by: saumeya <[email protected]> add test case Signed-off-by: saumeya <[email protected]> review comments Signed-off-by: saumeya <[email protected]> review comments Signed-off-by: saumeya <[email protected]> review comments Signed-off-by: saumeya <[email protected]> review comments Signed-off-by: saumeya <[email protected]> add e2e for the feature Signed-off-by: saumeya <[email protected]> uncommenting Signed-off-by: saumeya <[email protected]> rebase Signed-off-by: saumeya <[email protected]> changes: Signed-off-by: saumeya <[email protected]> changes Signed-off-by: saumeya <[email protected]> * bundle changes Signed-off-by: saumeya <[email protected]> * changes Signed-off-by: saumeya <[email protected]> * change Signed-off-by: saumeya <[email protected]> * change Signed-off-by: saumeya <[email protected]> * change Signed-off-by: saumeya <[email protected]> * changes Signed-off-by: saumeya <[email protected]> --------- Signed-off-by: saumeya <[email protected]> Co-authored-by: Abhishek Veeramalla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
To make metrics scraping optional in GitOps Operator
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
Edit the spec.monitoring field to false to disable scraping of metrics, like so
apiVersion: argoproj.io/v1beta1
kind: ArgoCD
metadata:
name: argocd-sample
namespace: default
spec:
monitoring:
disableMetrics: true
OR patch the resource using cli, like so
oc patch argocd argocd-sample -n default --type='json' -p='[{"op": "replace", "path": "/spec/monitoring/disableMetrics", "value": true}]'
To enable metrics for your instance, just change the spec.monitoring field to false, this will create the required role, rolebindings and service monitors and add the cluster-monitoring label to the namespace resource.
Disabling it will delete these resources and will also remove the cluster-monitoring label from the namespace resource.