add test case

Signed-off-by: saumeya <[email protected]>

Author: saumeya

controllers/argocd_metrics_controller_test.go

@@ -52,7 +52,7 @@ const (
 	argoCDInstanceName = "openshift-gitops"
 )
 
-func newClient(s *runtime.Scheme, namespace, name string) client.Client {
+func newClient(s *runtime.Scheme, namespace, name string, enableMonitoring bool) client.Client {
 	ns := corev1.Namespace{
 		ObjectMeta: v1.ObjectMeta{
 			Name: namespace,
@@ -65,17 +65,17 @@ func newClient(s *runtime.Scheme, namespace, name string) client.Client {
 		},
 		Spec: argoapp.ArgoCDSpec{
 			Monitoring: argoapp.ArgoCDMonitoringSpec{
-				Enabled: true,
+				Enabled: enableMonitoring,
 			},
 		},
 	}
 	return fake.NewClientBuilder().WithScheme(s).WithObjects(&ns, &argocd).Build()
 }
 
-func newMetricsReconciler(t *testing.T, namespace, name string) ArgoCDMetricsReconciler {
+func newMetricsReconciler(t *testing.T, namespace, name string, enableMonitoring bool) ArgoCDMetricsReconciler {
 	t.Helper()
 	s := newScheme()
-	c := newClient(s, namespace, name)
+	c := newClient(s, namespace, name, enableMonitoring)
 	r := ArgoCDMetricsReconciler{Client: c, Scheme: s}
 	return r
 }
@@ -95,7 +95,7 @@ func TestReconcile_add_namespace_label(t *testing.T) {
 		},
 	}
 	for _, tc := range testCases {
-		r := newMetricsReconciler(t, tc.namespace, tc.instanceName)
+		r := newMetricsReconciler(t, tc.namespace, tc.instanceName, true)
 		_, err := r.Reconcile(context.TODO(), newRequest(tc.namespace, tc.instanceName))
 		assert.NilError(t, err)
 
@@ -122,7 +122,7 @@ func TestReconcile_add_read_role(t *testing.T) {
 		},
 	}
 	for _, tc := range testCases {
-		r := newMetricsReconciler(t, tc.namespace, tc.instanceName)
+		r := newMetricsReconciler(t, tc.namespace, tc.instanceName, true)
 		_, err := r.Reconcile(context.TODO(), newRequest(tc.namespace, tc.instanceName))
 		assert.NilError(t, err)
 
@@ -165,7 +165,7 @@ func TestReconcile_add_read_role_binding(t *testing.T) {
 		},
 	}
 	for _, tc := range testCases {
-		r := newMetricsReconciler(t, tc.namespace, tc.instanceName)
+		r := newMetricsReconciler(t, tc.namespace, tc.instanceName, true)
 		_, err := r.Reconcile(context.TODO(), newRequest(tc.namespace, tc.instanceName))
 		assert.NilError(t, err)
 
@@ -209,7 +209,7 @@ func TestReconcile_add_service_monitors(t *testing.T) {
 		},
 	}
 	for _, tc := range testCases {
-		r := newMetricsReconciler(t, tc.namespace, tc.instanceName)
+		r := newMetricsReconciler(t, tc.namespace, tc.instanceName, true)
 		_, err := r.Reconcile(context.TODO(), newRequest(tc.namespace, tc.instanceName))
 		assert.NilError(t, err)
 
@@ -260,6 +260,45 @@ func TestReconcile_add_service_monitors(t *testing.T) {
 	}
 }
 
+func TestReconcile_remove_service_monitors(t *testing.T) {
+	testCases := []struct {
+		instanceName string
+		namespace    string
+	}{
+		{
+			instanceName: argoCDInstanceName,
+			namespace:    "openshift-gitops",
+		},
+		{
+			instanceName: "instance-two",
+			namespace:    "namespace-two",
+		},
+	}
+	for _, tc := range testCases {
+		r := newMetricsReconciler(t, tc.namespace, tc.instanceName, false)
+		_, err := r.Reconcile(context.TODO(), newRequest(tc.namespace, tc.instanceName))
+		assert.NilError(t, err)
+
+		serviceMonitor := monitoringv1.ServiceMonitor{}
+		serviceMonitorName := tc.instanceName
+
+		err = r.Client.Get(context.TODO(), types.NamespacedName{Name: serviceMonitorName, Namespace: tc.namespace}, &serviceMonitor)
+		assert.Error(t, err, err.Error())
+
+		serviceMonitor = monitoringv1.ServiceMonitor{}
+		serviceMonitorName = fmt.Sprintf("%s-server", tc.instanceName)
+
+		err = r.Client.Get(context.TODO(), types.NamespacedName{Name: serviceMonitorName, Namespace: tc.namespace}, &serviceMonitor)
+		assert.Error(t, err, err.Error())
+
+		serviceMonitor = monitoringv1.ServiceMonitor{}
+		serviceMonitorName = fmt.Sprintf("%s-repo-server", tc.instanceName)
+
+		err = r.Client.Get(context.TODO(), types.NamespacedName{Name: serviceMonitorName, Namespace: tc.namespace}, &serviceMonitor)
+		assert.Error(t, err, err.Error())
+	}
+}
+
 func TestReconciler_add_prometheus_rule(t *testing.T) {
 	testCases := []struct {
 		instanceName string
@@ -275,7 +314,7 @@ func TestReconciler_add_prometheus_rule(t *testing.T) {
 		},
 	}
 	for _, tc := range testCases {
-		r := newMetricsReconciler(t, tc.namespace, tc.instanceName)
+		r := newMetricsReconciler(t, tc.namespace, tc.instanceName, true)
 		_, err := r.Reconcile(context.TODO(), newRequest(tc.namespace, tc.instanceName))
 		assert.NilError(t, err)
 
@@ -323,7 +362,7 @@ func TestReconciler_add_dashboard(t *testing.T) {
 		},
 	}
 	for _, tc := range testCases {
-		r := newMetricsReconciler(t, tc.namespace, tc.instanceName)
+		r := newMetricsReconciler(t, tc.namespace, tc.instanceName, true)
 		// Create dashboard namespace
 		err := r.Client.Create(context.TODO(), &ns)
 		assert.NilError(t, err)