[build][cmake] Review web compilation system #5181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raysan5
reviewed
Sep 13, 2025
|
@brccabral Please, could you review the comments and the conflicts? |
raysan5
changed the title
|
@brccabral Thanks for the review! |
|
@brccabral Why did you delete projects/CMake/CMakeLists.txt? |
Peter0x44
added a commit
to Peter0x44/raylib
that referenced
this pull request
Sep 17, 2025
For some reason, raysan5#5181 deleted it. This project is intended to be a simple template to set up a project consuming raylib with CMake.
|
I moved it to examples/CMakeLists.txt, and the c file to examples/others/web_basic_window.c |
raysan5
pushed a commit
that referenced
this pull request
Sep 17, 2025
For some reason, #5181 deleted it. This project is intended to be a simple template to set up a project consuming raylib with CMake.
psxdev
pushed a commit
to raylib4Consoles/raylib
that referenced
this pull request
Sep 19, 2025
* [cmake] export automatically raylib definitions and compile/link options * [cmake] pass emscripten options to consumer project * [web] compile for web * [web] canvas width 100%
psxdev
pushed a commit
to raylib4Consoles/raylib
that referenced
this pull request
Sep 19, 2025
For some reason, raysan5#5181 deleted it. This project is intended to be a simple template to set up a project consuming raylib with CMake.
JohnnyCena123
added a commit
to JohnnyCena123/raylib
that referenced
this pull request
Sep 21, 2025
raysan5
pushed a commit
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes following discussion from #5180 .
Moved file
projects/CMake/core_basic_window.ctoexamples/others/web_basic_window.c.Removed target options from library to examples.