-
Notifications
You must be signed in to change notification settings - Fork 3k
Add support for Hibernate's hibernate.hbm2ddl.extra_physical_table_types #49996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for Hibernate's hibernate.hbm2ddl.extra_physical_table_types #49996
Conversation
/cc @gsmet (hibernate-orm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. There seems to be a few mistakes, please have a look?
We'll launch CI after you fixed that, because I'm pretty sure some tests would fail in the current state of the PR.
...eployment/src/test/java/io/quarkus/hibernate/orm/config/properties/ConfigPropertiesTest.java
Outdated
Show resolved
Hide resolved
...ime/src/main/java/io/quarkus/hibernate/orm/runtime/FastBootHibernatePersistenceProvider.java
Outdated
Show resolved
Hide resolved
...java/io/quarkus/hibernate/reactive/runtime/FastBootHibernateReactivePersistenceProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you. Let's see what CI thinks of it :)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Looks like there's a formatting issue :) See:
And: https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style |
done @yrodiere |
089ae92
to
190adcf
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Please squash and force push |
e30e2f1
to
a358aeb
Compare
done |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6e56f1b
to
85c9a19
Compare
This MR adds support for configuring additional database object types to be included
in schema management operations, such as materialized views or other database-specific objects.
Changes:
Example usage: quarkus.hibernate-orm.extra-physical-table-types=MATERIALIZED VIEW,VIEW