Skip to content

Conversation

Chu3laMan
Copy link

This MR adds support for configuring additional database object types to be included
in schema management operations, such as materialized views or other database-specific objects.

Changes:

Add documentation for the existing extraPhysicalTableTypes() method
Pass the configuration to Hibernate ORM in FastBootHibernatePersistenceProvider
Add the same implementation for Hibernate Reactive in FastBootHibernateReactivePersistenceProvider
Define a constant for the setting if not already available in Hibernate's AvailableSettings

Example usage: quarkus.hibernate-orm.extra-physical-table-types=MATERIALIZED VIEW,VIEW

@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive labels Sep 10, 2025
Copy link

quarkus-bot bot commented Sep 10, 2025

/cc @gsmet (hibernate-orm)

@Chu3laMan
Copy link
Author

Hi @geoand, @yrodiere.
I created a new one cause of I found a lot of conflict in the previous one, I hope that one will be enough.
I am gonna close the previous
Thank you,

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. There seems to be a few mistakes, please have a look?

We'll launch CI after you fixed that, because I'm pretty sure some tests would fail in the current state of the PR.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. Let's see what CI thinks of it :)

This comment has been minimized.

This comment has been minimized.

@yrodiere
Copy link
Member

Looks like there's a formatting issue :)

See:

File '/home/runner/_work/quarkus/quarkus/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/HibernateOrmRuntimeConfigPersistenceUnit.java' has not been previously formatted. Please format file (for example by invoking mvn -f extensions/hibernate-orm/runtime net.revelc.code.formatter:formatter-maven-plugin:2.27.0:format) and commit before running validation!

And: https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style

@Chu3laMan
Copy link
Author

Looks like there's a formatting issue :)

See:

File '/home/runner/_work/quarkus/quarkus/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/HibernateOrmRuntimeConfigPersistenceUnit.java' has not been previously formatted. Please format file (for example by invoking mvn -f extensions/hibernate-orm/runtime net.revelc.code.formatter:formatter-maven-plugin:2.27.0:format) and commit before running validation!

And: https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style

done @yrodiere

@Chu3laMan Chu3laMan force-pushed the feature/Add-support-for-Hibernate-hbm2ddl-extra-physical-table-types branch from 089ae92 to 190adcf Compare September 11, 2025 17:44
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 12, 2025

This comment has been minimized.

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Sep 12, 2025

Please squash and force push

@Chu3laMan Chu3laMan force-pushed the feature/Add-support-for-Hibernate-hbm2ddl-extra-physical-table-types branch from e30e2f1 to a358aeb Compare September 12, 2025 08:12
@Chu3laMan
Copy link
Author

Please squash and force push

done

This comment has been minimized.

This comment has been minimized.

@Chu3laMan Chu3laMan force-pushed the feature/Add-support-for-Hibernate-hbm2ddl-extra-physical-table-types branch from 6e56f1b to 85c9a19 Compare September 12, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/kubernetes triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a supported configuration property "hibernate.hbm2ddl.extra_physical_table_types"
3 participants