Add support for Hibernate's hibernate.hbm2ddl.extra_physical_table_types #49063

Chu3laMan · 2025-07-23T08:54:16Z

This MR adds support for configuring additional database object types to be included
in schema management operations, such as materialized views or other database-specific objects.

Changes:

Add documentation for the existing extraPhysicalTableTypes() method
Pass the configuration to Hibernate ORM in FastBootHibernatePersistenceProvider
Add the same implementation for Hibernate Reactive in FastBootHibernateReactivePersistenceProvider
Define a constant for the setting if not already available in Hibernate's AvailableSettings

Example usage: quarkus.hibernate-orm.extra-physical-table-types=MATERIALIZED VIEW,VIEW

quarkus-bot · 2025-07-23T08:54:37Z

/cc @gsmet (hibernate-orm)

Chu3laMan · 2025-07-23T08:58:13Z

Hi @geoand, I already closed the first one and opened this new PR

geoand · 2025-07-23T09:00:31Z

Thanks. This PR still contains merge commits. You'll need to rebase your branch onto main and then force push it

yrodiere · 2025-07-23T09:00:58Z

I'll do the rebase, let's not get to the same situation as before :)

geoand · 2025-07-23T09:02:03Z

The problem is that @Chu3laMan will need to make sure not to use their branch, but the updated one only

yrodiere

Looks like some unrelated changes crept in.

IMPORTANT: I rebased your branch and force-pushed. Please run git pull before resuming work on your local clone.

yrodiere · 2025-07-23T09:06:07Z

core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java

+    @BuildStep
+    @Produce(ServiceStartBuildItem.class)
+    void closeBuildTimeLogging(List<DevServicesResultBuildItem> devServices) {
+        if (devServices.isEmpty()) {
+            ((QuarkusClassLoader) Thread.currentThread().getContextClassLoader()).addCloseTask(new Runnable() {
+                @Override
+                public void run() {
+                    InitialConfigurator.DELAYED_HANDLER.buildTimeComplete();
+                }
+            });
+        }
+    }


How is this related? 🤔

While it's building at the Initial JDK 17 job, It highlighted an error there when I checked that class I found there is a method duplicated which is

void closeBuildTimeLogging(List devServices)

`
@Mac quarkus % grep -n "closeBuildTimeLogging" core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java
343: // When there is no devservices build time logging is still closed at deployment classloader close #closeBuildTimeLogging
556: void closeBuildTimeLogging(List devServices) {
569: void closeBuildTimeLogging(List devServices) {

`

yrodiere · 2025-07-23T09:06:26Z

core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigGenerationBuildStep.java

-                // Cache implementation types of nested elements
-                List<ConfigMappingMetadata> configMappingsMetadata = ConfigMappingLoader
-                        .getConfigMappingsMetadata(mapping.getType());
-                for (ConfigMappingMetadata configMappingMetadata : configMappingsMetadata) {
-                    clinit.invokeStaticMethod(ENSURE_LOADED, clinit.load(configMappingMetadata.getInterfaceType().getName()));
-                }
-


Same, changes in this file seem unrelated.

quarkus-bot · 2025-07-23T09:09:05Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 50e5982.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	Initial JDK 17 Build	`Build`	Failures	Logs	Raw logs	🔍

You can consult the Develocity build scans.

Failures

⚙️ Initial JDK 17 Build #

- Failing: core/deployment 
! Skipped: devtools/bom-descriptor-json devtools/cli devtools/gradle/gradle-application-plugin and 878 more

📦 core/deployment

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project quarkus-core-deployment: Compilation failure /home/runner/_work/quarkus/quarkus/core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java:[569,10] method closeBuildTimeLogging(java.util.List<io.quarkus.deployment.builditem.DevServicesResultBuildItem>) is already defined in class io.quarkus.deployment.logging.LoggingResourceProcessor

quarkus-bot · 2025-07-23T09:09:34Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 50e5982.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✖	Documentation Build	`Build`	Failures	Logs	Raw logs	🚧

Failures

⚙️ Documentation Build #

- Failing: core/deployment 
! Skipped: core/junit4-mock devtools/bom-descriptor-json devtools/cli and 1227 more

📦 core/deployment

✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project quarkus-core-deployment: Compilation failure /home/runner/work/quarkus/quarkus/core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java:[569,10] method closeBuildTimeLogging(java.util.List<io.quarkus.deployment.builditem.DevServicesResultBuildItem>) is already defined in class io.quarkus.deployment.logging.LoggingResourceProcessor

geoand · 2025-07-29T08:20:34Z

@Chu3laMan do you plan to push this one over the finish line?

cescoffier · 2025-08-25T06:45:01Z

@Chu3laMan ping?

Chu3laMan · 2025-08-25T08:40:28Z

@Chu3laMan ping?

Sorry for being late to reply back, I have done a cherry-pick to surpass the conflict however still getting the same issue.

cescoffier · 2025-08-25T09:53:12Z

Try to rebase on a clean branch.

Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec) from 1.18.0 to 1.19.0. - [Changelog](https://github.com/apache/commons-codec/blob/master/RELEASE-NOTES.txt) - [Commits](apache/commons-codec@rel/commons-codec-1.18.0...rel/commons-codec-1.19.0) --- updated-dependencies: - dependency-name: commons-codec:commons-codec dependency-version: 1.19.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) from 2.59.1 to 2.59.2. - [Release notes](https://github.com/googleapis/sdk-platform-java/releases) - [Changelog](https://github.com/googleapis/sdk-platform-java/blob/main/CHANGELOG.md) - [Commits](googleapis/sdk-platform-java@v2.59.1...v2.59.2) --- updated-dependencies: - dependency-name: com.google.api.grpc:proto-google-common-protos dependency-version: 2.59.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps `apicurio-registry.version` from 2.6.12.Final to 2.6.13.Final. Updates `io.apicurio:apicurio-registry-client` from 2.6.12.Final to 2.6.13.Final Updates `io.apicurio:apicurio-registry-serdes-avro-serde` from 2.6.12.Final to 2.6.13.Final Updates `io.apicurio:apicurio-registry-serdes-jsonschema-serde` from 2.6.12.Final to 2.6.13.Final --- updated-dependencies: - dependency-name: io.apicurio:apicurio-registry-client dependency-version: 2.6.13.Final dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.apicurio:apicurio-registry-serdes-avro-serde dependency-version: 2.6.13.Final dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.apicurio:apicurio-registry-serdes-jsonschema-serde dependency-version: 2.6.13.Final dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

github-actions · 2025-09-09T19:07:37Z

🙈 The PR is closed and the preview is expired.

Houssam El Mansouri and others added 4 commits July 12, 2025 13:39

Add support for Hibernate's hibernate.hbm2ddl.extra_physical_table_types

8186015

Merge remote-tracking branch 'origin/main'

b29bd43

Merge branch 'quarkusio:main' into main

9b813bc

Add support for Hibernate's hibernate.hbm2ddl.extra_physical_table_types

7f86bca

quarkus-bot bot added area/core area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive labels Jul 23, 2025

geoand mentioned this pull request Jul 23, 2025

Add support for Hibernate's hibernate.hbm2ddl.extra_physical_table_types #47921

Closed

yrodiere force-pushed the feature/47854-Add-a-supported-configuration-property-v2 branch from 2e5c076 to 50e5982 Compare July 23, 2025 09:04

yrodiere requested changes Jul 23, 2025

View reviewed changes

geoand and others added 7 commits September 9, 2025 18:49

Add GeneratedBeanGizmo2Adaptor for Gizmo2 generated beans

99dd767

Port Jackson extension to Gizmo2

43079b8

Support for customizing request and response body in OIDC filters

a4af106

Remove duplicate closeBuildTimeLogging method in LogginResourceProcessor

7a0a5d3

Chu3laMan force-pushed the feature/47854-Add-a-supported-configuration-property-v2 branch from 50e5982 to 7a0a5d3 Compare September 9, 2025 17:50

quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Sep 9, 2025

Chu3laMan closed this Sep 9, 2025

quarkus-bot bot added the triage/invalid This doesn't seem right label Sep 9, 2025

Chu3laMan reopened this Sep 9, 2025

quarkus-bot bot removed the triage/invalid This doesn't seem right label Sep 9, 2025

Chu3laMan mentioned this pull request Sep 10, 2025

Add support for Hibernate's hibernate.hbm2ddl.extra_physical_table_types #49996

Merged

Chu3laMan closed this Sep 10, 2025

quarkus-bot bot added the triage/invalid This doesn't seem right label Sep 10, 2025

Add support for Hibernate's hibernate.hbm2ddl.extra_physical_table_types #49063

Add support for Hibernate's hibernate.hbm2ddl.extra_physical_table_types #49063

Uh oh!

Conversation

Chu3laMan commented Jul 23, 2025 • edited by geoand Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quarkus-bot bot commented Jul 23, 2025

Uh oh!

Chu3laMan commented Jul 23, 2025

Uh oh!

geoand commented Jul 23, 2025

Uh oh!

yrodiere commented Jul 23, 2025

Uh oh!

geoand commented Jul 23, 2025

Uh oh!

yrodiere left a comment

Choose a reason for hiding this comment

Uh oh!

yrodiere Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Chu3laMan Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

yrodiere Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

quarkus-bot bot commented Jul 23, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status for workflow Quarkus CI

Failing Jobs

Failures

⚙️ Initial JDK 17 Build #

📦 core/deployment

Uh oh!

quarkus-bot bot commented Jul 23, 2025

Status for workflow Quarkus Documentation CI

Failing Jobs

Failures

⚙️ Documentation Build #

📦 core/deployment

Uh oh!

geoand commented Jul 29, 2025

Uh oh!

cescoffier commented Aug 25, 2025

Uh oh!

Chu3laMan commented Aug 25, 2025

Uh oh!

cescoffier commented Aug 25, 2025

Uh oh!

github-actions bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Chu3laMan commented Jul 23, 2025 •

edited by geoand

Loading

quarkus-bot bot commented Jul 23, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`

Status for workflow `Quarkus Documentation CI`

github-actions bot commented Sep 9, 2025 •

edited

Loading