Upgrade to golangci-lint v2 #1689
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,48 @@ | ||
| # WARNING: This file is autogenerated - changes will be overwritten when regenerated by https://github.com/pulumi/ci-mgmt | ||
|
|
||
| version: "2" | ||
| linters: | ||
| enable: | ||
| - goconst | ||
| - gosec | ||
| - lll | ||
| - misspell | ||
| - nakedret | ||
| - revive | ||
| - unconvert | ||
| exclusions: | ||
| generated: lax | ||
| presets: | ||
| - comments | ||
| - common-false-positives | ||
| - legacy | ||
| - std-error-handling | ||
| paths: | ||
| - schema.go | ||
| - pulumiManifest.go | ||
| - pkg/vendored | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
| formatters: | ||
| enable: | ||
| - gci | ||
| - gofmt | ||
| settings: | ||
| gci: | ||
| sections: | ||
| - standard | ||
| - blank | ||
| - default | ||
| - prefix(github.com/pulumi/) | ||
| - prefix(github.com/#{{ .Config.Organization }}#/pulumi-#{{ .Config.Provider }}#) | ||
| custom-order: true | ||
| exclusions: | ||
| generated: lax | ||
| paths: | ||
| - schema.go | ||
| - pulumiManifest.go | ||
| - pkg/vendored | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,7 @@ dotnet = '#{{ trimSuffix ".x" .Config.ToolVersions.Dotnet }}#' | |
| java = 'corretto-#{{trimSuffix ".x" .Config.ToolVersions.Java }}#' | ||
|
|
||
| # Executable tools | ||
| golangci-lint = 'v2.4.0' | ||
|
There was a problem hiding this comment. This should be read from toolVersions in ci-mgmt.yaml like the rest of these tools. There was a problem hiding this comment. @blampe it didn't before my change. If needed, I would like to implement that in a separate PR. There was a problem hiding this comment. Right, that's the bug to fix. We should just fix it directly, no need to break builds in the interim. |
||
| pulumi = 'latest' | ||
| "go:github.com/pulumi/pulumictl/cmd/pulumictl" = 'latest' | ||
| gradle = '#{{ trimSuffix ".x" .Config.ToolVersions.Gradle }}#' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,48 @@ | ||
| # WARNING: This file is autogenerated - changes will be overwritten when regenerated by https://github.com/pulumi/ci-mgmt | ||
|
|
||
| version: "2" | ||
| linters: | ||
| enable: | ||
| - goconst | ||
| - gosec | ||
| - lll | ||
| - misspell | ||
| - nakedret | ||
| - revive | ||
| - unconvert | ||
| exclusions: | ||
| generated: lax | ||
| presets: | ||
| - comments | ||
| - common-false-positives | ||
| - legacy | ||
| - std-error-handling | ||
| paths: | ||
| - schema.go | ||
| - pulumiManifest.go | ||
| - pkg/vendored | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
| formatters: | ||
| enable: | ||
| - gci | ||
| - gofmt | ||
| settings: | ||
| gci: | ||
| sections: | ||
| - standard | ||
| - blank | ||
| - default | ||
| - prefix(github.com/pulumi/) | ||
| - prefix(github.com/pulumiverse/pulumi-acme) | ||
| custom-order: true | ||
| exclusions: | ||
| generated: lax | ||
| paths: | ||
| - schema.go | ||
| - pulumiManifest.go | ||
| - pkg/vendored | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,48 @@ | ||
| # WARNING: This file is autogenerated - changes will be overwritten when regenerated by https://github.com/pulumi/ci-mgmt | ||
|
|
||
| version: "2" | ||
| linters: | ||
| enable: | ||
| - goconst | ||
| - gosec | ||
| - lll | ||
| - misspell | ||
| - nakedret | ||
| - revive | ||
| - unconvert | ||
| exclusions: | ||
| generated: lax | ||
| presets: | ||
| - comments | ||
| - common-false-positives | ||
| - legacy | ||
| - std-error-handling | ||
| paths: | ||
| - schema.go | ||
| - pulumiManifest.go | ||
| - pkg/vendored | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
| formatters: | ||
| enable: | ||
| - gci | ||
| - gofmt | ||
| settings: | ||
| gci: | ||
| sections: | ||
| - standard | ||
| - blank | ||
| - default | ||
| - prefix(github.com/pulumi/) | ||
| - prefix(github.com/pulumi/pulumi-aws) | ||
| custom-order: true | ||
| exclusions: | ||
| generated: lax | ||
| paths: | ||
| - schema.go | ||
| - pulumiManifest.go | ||
| - pkg/vendored | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep formatting changes separate. It's too hard to tell what's actually changing vs. what's just reformatted.