Upgrade to golangci-lint v2 #1689
Conversation
There was a problem hiding this comment.
Doing a blanket upgrade like this will break a lot of provider builds until we manually resolve these lint issues. That's not a good use of time.
Instead it should be possible for a provider to opt-in to their own version of the linter and we should respect that in the workflows.
| - errcheck | ||
| - gci | ||
| - goconst | ||
| - gofmt | ||
| - gosec | ||
| - govet | ||
| - ineffassign | ||
| - lll | ||
| - gosimple | ||
| - staticcheck | ||
| - misspell | ||
| - nakedret | ||
| - revive | ||
| - unconvert | ||
| - unused | ||
| enable-all: false | ||
| issues: | ||
| exclude-dirs: | ||
| - pkg/vendored | ||
| exclude-files: | ||
| - schema.go | ||
| - pulumiManifest.go | ||
| run: | ||
| timeout: 20m | ||
| linters-settings: | ||
| gci: | ||
| sections: | ||
| - standard # Standard section: captures all standard library packages. | ||
| - blank # Blank section: contains all blank imports. | ||
| - default # Default section: contains all imports that could not be matched to another section type. | ||
| - prefix(github.com/pulumi/) # Custom section: groups all imports with the github.com/pulumi/ prefix. | ||
| - prefix(github.com/#{{ .Config.Organization }}#/pulumi-#{{ .Config.Provider }}#) # Custom section: local imports | ||
| custom-order: true | ||
| - goconst | ||
| - gosec | ||
| - lll | ||
| - misspell |
There was a problem hiding this comment.
Please keep formatting changes separate. It's too hard to tell what's actually changing vs. what's just reformatted.
| @@ -11,6 +11,7 @@ dotnet = '#{{ trimSuffix ".x" .Config.ToolVersions.Dotnet }}#' | |||
| java = 'corretto-#{{trimSuffix ".x" .Config.ToolVersions.Java }}#' | |||
|
|
|||
| # Executable tools | |||
| golangci-lint = 'v2.4.0' | |||
There was a problem hiding this comment.
This should be read from toolVersions in ci-mgmt.yaml like the rest of these tools.
There was a problem hiding this comment.
@blampe it didn't before my change. If needed, I would like to implement that in a separate PR.
There was a problem hiding this comment.
Right, that's the bug to fix. We should just fix it directly, no need to break builds in the interim.
|
I'm deep down on Neo work so I'll let @blampe tackle this unless you need me! TYVM. |
Fixes: #1543
.golangci.ymlconfig file tov2lint.ymlworkflow togolangci-lintv2.4.0 andgov1.24.0. The Go version in this workflow is separate from the configured Go version for the rest of the workflows.mise.tomlfor consistencyChanges from this branch were tested manually on a Pulumiverse provider:
(need to investigate the license check error in my runs, but thes are unrelated to the lint changes)