Uuid indices #98

ewolinetz · 2016-03-21T22:19:55Z

This is to address https://bugzilla.redhat.com/show_bug.cgi?id=1316216

Need to update documentation to better describe upgrade path and running of the uuid_migration script.

In the mean time comments welcome @richm @sosiouxme @jcantrill

jcantrill · 2016-03-22T13:01:29Z

fluentd/configs.d/filter/k8s_record_transform.conf

@@ -4,7 +4,7 @@
  <record>
    hostname ${(kubernetes_host rescue nil) || File.open('/etc/docker-hostname') { |f| f.readline }.rstrip}
    message ${log}
-    version 1.0.6
+    version 1.1.4


I see we are bumping these versions here. Are they needed for the PR or is it just an opportunity to upgrade?

So this is just a marker for the data. Since we're making some bigger
changes like adding new data and changing the index formatting this was an
appropriate time to up this version.
On Mar 22, 2016 8:01 AM, "Jeff Cantrill" [email protected] wrote:

In fluentd/configs.d/filter/k8s_record_transform.conf
#98 (comment)
:

@@ -4,7 +4,7 @@

hostname ${(kubernetes_host rescue nil) || File.open('/etc/docker-hostname') { |f| f.readline }.rstrip}
message ${log}

version 1.0.6

version 1.1.4

I see we are bumping these versions here. Are they needed for the PR or is
it just an opportunity to upgrade?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/openshift/origin-aggregated-logging/pull/98/files/15769affe2fb22e7a8cdb1660ed0b2fe125879b5#r56981288

ewolinetz · 2016-03-22T16:07:31Z

Addressed suggestions made by Rich and added to the README to expand on the migration path

ewolinetz · 2016-03-22T16:31:05Z

[test]

ewolinetz · 2016-03-22T21:42:32Z

hack/scripts/uuid_migration.sh

+fi
+
+OPS_PROJECTS=("default" "openshift" "openshift-infra")
+PROJECTS=(oc get project -o jsonpath='{.items[*].metadata.name}')


this needs to be in ticks

ewolinetz · 2016-03-23T15:30:02Z

[test]

ewolinetz · 2016-03-23T16:50:05Z

@sosiouxme @richm @jcantrill PTAL

sosiouxme · 2016-03-24T14:21:54Z

README.md

+
+Be sure to delete your routes and oauth client
+
+    $ oc delete route,oauthclient --selector logging-infra=support


I think we should really just update the code to delete the route as well. But the oauthclient, yeah, they need to do that :(

sosiouxme · 2016-03-24T15:46:28Z

I wish I had more time to look at this today, but I probably won't. I've had time to at least glance over most of it and I don't have any qualms at this point.

ewolinetz · 2016-03-24T20:37:18Z

[test]

ewolinetz · 2016-03-28T20:05:21Z

[test]

richm · 2016-03-29T00:22:52Z

deployment/scripts/install.sh

@@ -262,7 +262,8 @@ fi

 if [ "${KEEP_SUPPORT}" != true ]; then
 	oc delete template --selector logging-infra=support
-	oc process -f templates/support.yaml -v "OAUTH_SECRET=$(cat $dir/oauth-secret),KIBANA_HOSTNAME=${hostname},KIBANA_OPS_HOSTNAME=${ops_hostname},IMAGE_PREFIX=${image_prefix},IMAGE_VERSION=${image_version}" | oc create -f -
+	oc process -f templates/support.yaml -v "OAUTH_SECRET=$(cat $dir/oauth-secret),KIBANA_HOSTNAME=${hostname},KIBANA_OPS_HOSTNAME=${ops_hostname}" | oc create -f -
+  oc process -f templates/images.yaml -v "IMAGE_PREFIX=${image_prefix},IMAGE_VERSION=${image_version}" | oc create -f -


indentation

richm · 2016-03-29T00:24:18Z

Would you please squash these into a single commit?

ewolinetz · 2016-03-29T16:01:04Z

[test]

ewolinetz · 2016-03-31T16:33:09Z

[test]

ewolinetz · 2016-03-31T18:36:40Z

[test]

…rove deployer process

openshift-bot · 2016-03-31T19:25:22Z

Evaluated for aggregated logging test up to 1e627fe

openshift-bot · 2016-03-31T20:01:18Z

Aggregated Logging Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-origin-aggregated-logging/101/)

ewolinetz · 2016-03-31T20:27:18Z

now doing migration script testing in addition to our previous tests. PTAL

richm · 2016-03-31T21:02:26Z

lgtm

richm · 2016-03-31T21:26:04Z

I think addition of the system.admin with "superuser" privileges should be in a separate commit, based on the feedback we are getting on the lack of curator in current versions.

ewolinetz · 2016-03-31T21:41:37Z

@richm that just impacts OSE though right? We have those changes already in place and they are currently ON_QA for https://bugzilla.redhat.com/show_bug.cgi?id=1316216

richm · 2016-03-31T21:47:08Z

@ewolinetz yes, so it's not really needed for origin. In general, it's bad to address multiple bugs/features in a single patch, because it is much harder to construct an audit trail, backport/cherry pick, etc. I guess in this case it's ok, as long as we can document what to do for OSE users.

ewolinetz · 2016-03-31T21:50:53Z

@richm agreed, this PR became very large very quick and that admin user change was caught up in it unfortunately.

sosiouxme · 2016-03-31T23:19:55Z

Probably don't need to squash everything to one commit, can keep them
broken out by major features/bugs. We just don't want to see a dozen fiddly
commits on the same thing.

On Thu, Mar 31, 2016 at 5:50 PM, Eric Wolinetz [email protected]
wrote:

@richm https://github.com/richm agreed, this PR became very large very
quick and that admin user change was caught up in it unfortunately.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#98 (comment)

assumes the changes from openshift/origin-aggregated-logging#98

richm · 2016-04-01T15:47:01Z

aos-ci-test

richm · 2016-04-01T15:52:49Z

aos-ci-test

richm · 2016-04-01T16:30:46Z

aos-ci-test

richm · 2016-04-01T16:32:56Z

aos-ci-test

richm · 2016-04-01T16:40:14Z

aos-ci-test

richm · 2016-04-01T16:53:05Z

aos-ci-test

richm · 2016-04-01T19:25:57Z

aos-ci-test

richm · 2016-04-01T19:36:19Z

aos-ci-test

sosiouxme · 2016-04-01T19:46:03Z

LGTM

assumes the changes from openshift/origin-aggregated-logging#98

jcantrill reviewed Mar 22, 2016
View reviewed changes

ewolinetz force-pushed the uuid_indices branch from f8fe495 to cefd890 Compare March 22, 2016 16:05

ewolinetz changed the title ~~[WIP] Uuid indices~~ Uuid indices Mar 22, 2016

ewolinetz mentioned this pull request Mar 22, 2016

Port logging EFK upgrade docs over from github README. openshift/openshift-docs#1761

Closed

ewolinetz force-pushed the uuid_indices branch 3 times, most recently from 5aabc9f to 3300bca Compare March 22, 2016 18:35

ewolinetz reviewed Mar 22, 2016
View reviewed changes

ewolinetz force-pushed the uuid_indices branch 2 times, most recently from 9999d50 to 73cb6eb Compare March 23, 2016 15:29

ewolinetz force-pushed the uuid_indices branch from 7acdcb8 to 22d2061 Compare March 23, 2016 16:48

ewolinetz force-pushed the uuid_indices branch from 4e8e54f to a89f301 Compare March 23, 2016 18:36

sosiouxme reviewed Mar 24, 2016
View reviewed changes

richm reviewed Mar 29, 2016
View reviewed changes

ewolinetz changed the title ~~Uuid indices~~ [DO_NOT_MERGE] Uuid indices Mar 29, 2016

ewolinetz force-pushed the uuid_indices branch 2 times, most recently from 3256430 to c34b546 Compare March 29, 2016 15:12

ewolinetz force-pushed the uuid_indices branch from 82b1ff5 to bfd9f5b Compare March 31, 2016 18:36

Changes to accomodate uuid_indices including migration script and imp…

1e627fe

…rove deployer process

ewolinetz force-pushed the uuid_indices branch from bfd9f5b to 1e627fe Compare March 31, 2016 19:24

sosiouxme added a commit to sosiouxme/openshift-docs that referenced this pull request Apr 1, 2016

logging: update for latest origin changes

c50e3ce

assumes the changes from openshift/origin-aggregated-logging#98

ewolinetz merged commit eeddd3d into openshift:master Apr 1, 2016

ahardin-rh pushed a commit to ahardin-rh/openshift-docs that referenced this pull request Apr 4, 2016

logging: update for latest origin changes

4cc49ba

assumes the changes from openshift/origin-aggregated-logging#98

ewolinetz deleted the uuid_indices branch April 12, 2016 19:35


		Be sure to delete your routes and oauth client

		$ oc delete route,oauthclient --selector logging-infra=support

Uuid indices #98

Uuid indices #98

Uh oh!

Conversation

ewolinetz commented Mar 21, 2016

Uh oh!

jcantrill Mar 22, 2016

Choose a reason for hiding this comment

Uh oh!

ewolinetz Mar 22, 2016

Choose a reason for hiding this comment

Uh oh!

ewolinetz commented Mar 22, 2016

Uh oh!

ewolinetz commented Mar 22, 2016

Uh oh!

ewolinetz Mar 22, 2016

Choose a reason for hiding this comment

Uh oh!

ewolinetz commented Mar 23, 2016

Uh oh!

ewolinetz commented Mar 23, 2016

Uh oh!

sosiouxme Mar 24, 2016

Choose a reason for hiding this comment

Uh oh!

sosiouxme commented Mar 24, 2016

Uh oh!

ewolinetz commented Mar 24, 2016

Uh oh!

ewolinetz commented Mar 28, 2016

Uh oh!

richm Mar 29, 2016

Choose a reason for hiding this comment

Uh oh!

richm commented Mar 29, 2016

Uh oh!

ewolinetz commented Mar 29, 2016

Uh oh!

ewolinetz commented Mar 31, 2016

Uh oh!

ewolinetz commented Mar 31, 2016

Uh oh!

openshift-bot commented Mar 31, 2016

Uh oh!

openshift-bot commented Mar 31, 2016

Uh oh!

ewolinetz commented Mar 31, 2016

Uh oh!

richm commented Mar 31, 2016

Uh oh!

richm commented Mar 31, 2016

Uh oh!

ewolinetz commented Mar 31, 2016

Uh oh!

richm commented Mar 31, 2016

Uh oh!

ewolinetz commented Mar 31, 2016

Uh oh!

sosiouxme commented Mar 31, 2016

Uh oh!

richm commented Apr 1, 2016

Uh oh!

richm commented Apr 1, 2016

Uh oh!

richm commented Apr 1, 2016

Uh oh!

richm commented Apr 1, 2016

Uh oh!

richm commented Apr 1, 2016

Uh oh!

richm commented Apr 1, 2016

Uh oh!

richm commented Apr 1, 2016

Uh oh!

richm commented Apr 1, 2016

Uh oh!

sosiouxme commented Apr 1, 2016

Uh oh!

Uh oh!