Skip to content

Conversation

opokornyy
Copy link
Contributor

InsightsConfigAPI is not used anywhere so I am removing it with this PR.

@opokornyy opokornyy changed the title feat: remove unused feature gate InsightsConfigAPI remove unused feature gate InsightsConfigAPI Sep 12, 2025
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

Hello @opokornyy! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2025
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: opokornyy
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed
Copy link
Contributor

CI is showing panics in the insights operator, looks like it is using this gate?

@opokornyy
Copy link
Contributor Author

CI is showing panics in the insights operator, looks like it is using this gate?

Oh, you are right. We are checking this gate, but the InsightsConfig should be used instead...

Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

@opokornyy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure e278f00 link false /test e2e-azure
ci/prow/e2e-upgrade-out-of-change e278f00 link true /test e2e-upgrade-out-of-change
ci/prow/okd-scos-e2e-aws-ovn e278f00 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-serial-techpreview-2of2 e278f00 link true /test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-aws-serial-2of2 e278f00 link true /test e2e-aws-serial-2of2
ci/prow/e2e-aws-ovn-techpreview e278f00 link true /test e2e-aws-ovn-techpreview
ci/prow/minor-e2e-upgrade-minor e278f00 link true /test minor-e2e-upgrade-minor
ci/prow/e2e-aws-ovn-hypershift-conformance e278f00 link true /test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-gcp e278f00 link false /test e2e-gcp
ci/prow/e2e-aws-ovn e278f00 link true /test e2e-aws-ovn
ci/prow/e2e-aws-serial-1of2 e278f00 link true /test e2e-aws-serial-1of2
ci/prow/e2e-aws-ovn-hypershift e278f00 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-upgrade e278f00 link true /test e2e-upgrade
ci/prow/e2e-aws-serial-techpreview-1of2 e278f00 link true /test e2e-aws-serial-techpreview-1of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/hold

@opokornyy I'll let you get that fixed up in the insights operator, once that merges, cancel the hold and ping me please

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2025
@opokornyy
Copy link
Contributor Author

PR link - openshift/insights-operator#1137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants