Skip to content

Simplify charter approval #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Simplify charter approval #1605

wants to merge 8 commits into from

Conversation

tobie
Copy link
Contributor

@tobie tobie commented Sep 9, 2025

No description provided.

@tobie
Simplify charter approval
de14eed 
Signed-off-by: Tobie Langel <[email protected]>
joesepi
joesepi reviewed Sep 9, 2025
View reviewed changes
tobie and others added 5 commits September 9, 2025 21:02
@tobie tobie marked this pull request as ready for review September 9, 2025 19:19
@tobie tobie requested a review from a team as a code owner September 9, 2025 19:19
@tobie
Add link to issue
2d507b7 
Signed-off-by: Tobie Langel <[email protected]>
joesepi
joesepi approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I like the change from required approval of two members bumped up to 5 and the duration of the request being reduced from 2 weeks to 72hrs. But I defer to the group consensus on those two points.

@ljharb
Copy link
Member

ljharb commented Sep 9, 2025

I think the 2 to 5 is good, but I think it should stay at 2 weeks. Charters are tough to change and slow approvals isn't holding anything back that I can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joesepi joesepi joesepi approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@rxmarbles rxmarbles rxmarbles approved these changes

@erickzhao erickzhao erickzhao approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tobie @ljharb @joesepi @UlisesGascon @rxmarbles @erickzhao @bjohansebas