Skip to content

Add mcp4725 module #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2017
Merged

Add mcp4725 module #1966

merged 3 commits into from
May 21, 2017

Conversation

dnc40085
Copy link
Contributor

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/en/*.

This PR adds a module for the MCP4725 12-bit Digital to Analog Converter.

@marcelstoer marcelstoer added this to the 2.1 follow-up milestone May 15, 2017
devsaurus
devsaurus approved these changes May 18, 2017
View reviewed changes
Copy link
Member

@devsaurus devsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though not tested myself due to lack of hardware.
Thanks a lot for your contribution!

@marcelstoer marcelstoer merged commit e90ffb4 into nodemcu:dev May 21, 2017
@dnc40085 dnc40085 deleted the dev_add_mcp4725 branch May 24, 2017 14:20
eiselekd pushed a commit to eiselekd/nodemcu-firmware that referenced this pull request Jan 7, 2018
@dnc40085
Add mcp4725 module (nodemcu#1966)
9954883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsaurus devsaurus devsaurus approved these changes

Assignees
No one assigned
Labels
new module
Projects
None yet
Milestone
2.1 follow-up
Development

Successfully merging this pull request may close these issues.
3 participants
@dnc40085 @devsaurus @marcelstoer