feat: Add config switch to enable E2EE in browser #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
3. to review
10 tasks
5 tasks
artonge
force-pushed
the
artonge/feat/add_e2ee_in_browser_switch
branch
from
1fb0fb4 to
fe5a646
Compare
skjnldsv
reviewed
Dec 19, 2024
Comment on lines
35
to
+42
|
|
||
| $this->initialState->provideInitialState( | ||
| 'userConfig', | ||
| [ | ||
| 'e2eeInBrowserEnabled' => $this->config->getUserValue($this->userId, 'end_to_end_encryption', 'e2eeInBrowserEnabled', 'false') === 'true', | ||
| ] | ||
| ); | ||
|
|
There was a problem hiding this comment.
I would prefer a capability :)
There was a problem hiding this comment.
That a user setting, not a capability of the server, no?
There was a problem hiding this comment.
Some capabilities (like theming) changes per user 🤔
Maybe it is an antipattern 🤔
There was a problem hiding this comment.
artonge
force-pushed
the
artonge/feat/add_e2ee_in_browser_switch
branch
from
fe5a646 to
13c104b
Compare
nfebe
approved these changes
Dec 19, 2024
|
/compile amend / |
Signed-off-by: Louis Chemineau <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
artonge/feat/add_e2ee_in_browser_switch
branch
from
13c104b to
d0eb013
Compare
come-nc
reviewed
Dec 19, 2024
Comment on lines
+30
to
+43
| #[NoAdminRequired] | ||
| #[FrontpageRoute(verb: 'PUT', url: '/api/v1/config/{key}')] | ||
| public function setUserConfig(string $key, string $value): JSONResponse { | ||
| if (is_null($this->userId)) { | ||
| return new JSONResponse([], Http::STATUS_PRECONDITION_FAILED); | ||
| } | ||
|
|
||
| if (!in_array($key, ['e2eeInBrowserEnabled'])) { | ||
| return new JSONResponse([], Http::STATUS_PRECONDITION_FAILED); | ||
| } | ||
|
|
||
| $this->config->setUserValue($this->userId, Application::APP_ID, $key, $value); | ||
| return new JSONResponse([], Http::STATUS_OK); | ||
| } |
There was a problem hiding this comment.
Is there no route from core API for this?
There was a problem hiding this comment.
Nothing that I found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I also added a warning in the mnemonic prompt as E2EE navigation in browser could be maliciously enabled by the admin.
Settings
Mnemonic prompt