Skip to content

feat: Minimal support E2EE file navigation in browser #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 17, 2024
Merged

feat: Minimal support E2EE file navigation in browser #822

merged 7 commits into from
Dec 17, 2024

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Dec 5, 2024 •
edited
Loading

Todo

  • Add interceptor in a service worker
  • Parse and stringify request transparently for the front-end
  • Detect GET request on E2EE files
  • Fetch metadata
  • Fetch private key
    • Get mnemonic from the user
  • Decrypt metadata
  • Replace placeholder information in PROPFIND with the real from the metadata
  • Decrypt file on the fly
  • Show warning if user is in HTTP

Fix nextcloud/server#49649

@artonge artonge added 3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket php Pending a documentation update/fix labels Dec 5, 2024
@artonge artonge added this to the Nextcloud 31 milestone Dec 5, 2024
@artonge artonge self-assigned this Dec 5, 2024
@artonge artonge added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 5, 2024
@joshtrichards joshtrichards mentioned this pull request Dec 5, 2024
Closed
@artonge artonge force-pushed the artonge/feat/support_e2ee_in_browser branch 3 times, most recently from 97d5cb3 to 9cdac40 Compare December 16, 2024 19:44
@artonge artonge marked this pull request as ready for review December 17, 2024 09:05
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 17, 2024
@artonge artonge force-pushed the artonge/feat/support_e2ee_in_browser branch 9 times, most recently from 57a8db8 to 41a3008 Compare December 17, 2024 11:35
@sorbaugh sorbaugh requested a review from skjnldsv December 17, 2024 12:38
@sorbaugh
Copy link

sorbaugh commented Dec 17, 2024 •
edited
Loading

Add toggle to enable E2EE in browser - Is it needed?

I'm afraid yes, but this can be easily added later in a separate PR.

EDIT: More info. Since this issue can be seen as comfort by weakening security, it should be Opt-In and disabled by default.

@artonge artonge force-pushed the artonge/feat/support_e2ee_in_browser branch from d0ba280 to ecaf133 Compare December 17, 2024 14:55
@artonge artonge force-pushed the artonge/feat/support_e2ee_in_browser branch 2 times, most recently from 7096474 to 63e777b Compare December 17, 2024 15:16
nfebe
nfebe approved these changes Dec 17, 2024
View reviewed changes
@artonge artonge force-pushed the artonge/feat/support_e2ee_in_browser branch from 63e777b to c2ccb56 Compare December 17, 2024 15:39
@artonge
chore: Switch to vite to build frontend
59977e0 
And support typescript

Signed-off-by: Louis Chemineau <[email protected]>
@artonge
feat: Add E2EE files navigation
ae5a88b 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge
feat: Allow access to E2EE folder when x-e2ee-supported header is set
11aefe3 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge
test: Do not fail php unit test on warning
a9d8212 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge
chore: Update phpunit
c40a7b5 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge
chore: Compile assets
21def52 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/feat/support_e2ee_in_browser branch from c2ccb56 to 21def52 Compare December 17, 2024 15:52
@artonge artonge changed the title feat: Support E2EE in browser feat: Miniaml support E2EE file navigation in browser Dec 17, 2024
@artonge artonge changed the title feat: Miniaml support E2EE file navigation in browser feat: Minimal support E2EE file navigation in browser Dec 17, 2024
@artonge
chore: Fix reuse licences
51ba7cf 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge merged commit e3f29bf into master Dec 17, 2024
41 checks passed
@artonge artonge deleted the artonge/feat/support_e2ee_in_browser branch December 17, 2024 16:21
@artonge artonge mentioned this pull request Dec 18, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfebe nfebe nfebe approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@provokateurin provokateurin Awaiting requested review from provokateurin

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket php Pending a documentation update/fix
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

Add opt-in option to work with E2EE encrypted files in Web Interface
4 participants
@artonge @sorbaugh @nfebe @skjnldsv