Skip to content

Switch let/const to var in the scanner for top-levelish variables. #52833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Switch let/const to var in the scanner for top-levelish variables. #52833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions src/compiler/scanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,31 +961,32 @@ export function createScanner(languageVersion: ScriptTarget,
start?: number,
length?: number): Scanner {

let text = textInitial!;
/* eslint-disable no-var */
var text = textInitial!;

// Current position (end position of text of current token)
let pos: number;
var pos: number;


// end of text
let end: number;
var end: number;

// Start position of whitespace before current token
let startPos: number;
var startPos: number;

// Start position of text of current token
let tokenPos: number;
var tokenPos: number;

let token: SyntaxKind;
let tokenValue!: string;
let tokenFlags: TokenFlags;
var token: SyntaxKind;
var tokenValue!: string;
var tokenFlags: TokenFlags;

let commentDirectives: CommentDirective[] | undefined;
let inJSDocType = 0;
var commentDirectives: CommentDirective[] | undefined;
var inJSDocType = 0;

setText(text, start, length);

const scanner: Scanner = {
var scanner: Scanner = {
getStartPos: () => startPos,
getTextPos: () => pos,
getToken: () => token,
Expand Down Expand Up @@ -1031,6 +1032,8 @@ export function createScanner(languageVersion: ScriptTarget,
scanRange,
};

/* eslint-disable no-var */

if (Debug.isDebugging) {
Object.defineProperty(scanner, "__debugShowCurrentPositionInText", {
get: () => {
Expand Down