Skip to content

Conversation

jakebailey
Copy link
Member

Just testing to see what part of #52832 is the scanner only.

Probably will iterate on this more because I suspect it might just be pos or something.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 17, 2023
@jakebailey
Copy link
Member Author

@typescript-bot perf test faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 17, 2023

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at f0fc423. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52833

Metric main 52833 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 359,093k (± 0.01%) 358,939k (± 0.00%) -154k (- 0.04%) 358,920k 358,962k p=0.005 n=6
Parse Time 4.16s (± 0.42%) 3.83s (± 0.51%) 🟩-0.33s (- 8.05%) 3.81s 3.86s p=0.005 n=6
Bind Time 1.24s (± 0.33%) 1.24s (± 0.41%) ~ 1.24s 1.25s p=0.595 n=6
Check Time 9.52s (± 0.44%) 9.53s (± 0.19%) ~ 9.50s 9.55s p=0.935 n=6
Emit Time 8.10s (± 0.68%) 8.08s (± 0.42%) ~ 8.02s 8.12s p=0.687 n=6
Total Time 23.02s (± 0.40%) 22.68s (± 0.23%) -0.35s (- 1.50%) 22.62s 22.77s p=0.005 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 191,731k (± 0.02%) 191,579k (± 0.03%) -152k (- 0.08%) 191,542k 191,683k p=0.005 n=6
Parse Time 1.81s (± 0.97%) 1.60s (± 0.76%) 🟩-0.21s (-11.62%) 1.58s 1.61s p=0.005 n=6
Bind Time 0.84s (± 0.48%) 0.84s (± 0.48%) ~ 0.84s 0.85s p=1.000 n=6
Check Time 10.13s (± 0.70%) 10.18s (± 0.43%) ~ 10.13s 10.23s p=0.172 n=6
Emit Time 3.04s (± 0.70%) 3.04s (± 1.58%) ~ 2.96s 3.09s p=1.000 n=6
Total Time 15.82s (± 0.62%) 15.65s (± 0.47%) -0.17s (- 1.05%) 15.54s 15.74s p=0.008 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,537k (± 0.01%) 343,383k (± 0.01%) -154k (- 0.04%) 343,343k 343,447k p=0.005 n=6
Parse Time 3.10s (± 0.53%) 2.86s (± 0.57%) 🟩-0.23s (- 7.48%) 2.84s 2.88s p=0.005 n=6
Bind Time 1.11s (± 0.73%) 1.11s (± 0.49%) ~ 1.11s 1.12s p=0.859 n=6
Check Time 7.79s (± 0.70%) 7.78s (± 0.27%) ~ 7.75s 7.81s p=0.747 n=6
Emit Time 4.51s (± 0.33%) 4.50s (± 0.72%) ~ 4.46s 4.55s p=0.460 n=6
Total Time 16.51s (± 0.37%) 16.27s (± 0.21%) -0.25s (- 1.49%) 16.22s 16.30s p=0.005 n=6
TFS - node (v16.17.1, x64)
Memory used 299,646k (± 0.00%) 299,514k (± 0.00%) -133k (- 0.04%) 299,500k 299,530k p=0.005 n=6
Parse Time 2.45s (± 1.08%) 2.28s (± 0.45%) 🟩-0.17s (- 7.01%) 2.26s 2.29s p=0.005 n=6
Bind Time 1.26s (± 0.65%) 1.25s (± 0.44%) ~ 1.25s 1.26s p=0.859 n=6
Check Time 7.23s (± 0.43%) 7.21s (± 0.30%) ~ 7.18s 7.24s p=0.295 n=6
Emit Time 4.21s (± 0.47%) 4.22s (± 0.65%) ~ 4.18s 4.26s p=0.872 n=6
Total Time 15.14s (± 0.29%) 14.95s (± 0.26%) -0.19s (- 1.25%) 14.90s 15.02s p=0.005 n=6
material-ui - node (v16.17.1, x64)
Memory used 475,972k (± 0.00%) 475,818k (± 0.00%) -154k (- 0.03%) 475,791k 475,857k p=0.005 n=6
Parse Time 3.68s (± 0.24%) 3.42s (± 0.24%) 🟩-0.26s (- 6.97%) 3.41s 3.43s p=0.004 n=6
Bind Time 1.02s (± 0.62%) 1.02s (± 0.40%) ~ 1.01s 1.02s p=0.673 n=6
Check Time 18.31s (± 1.24%) 18.21s (± 0.46%) ~ 18.13s 18.34s p=0.936 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.01s (± 0.97%) 22.65s (± 0.37%) -0.36s (- 1.56%) 22.57s 22.78s p=0.005 n=6
xstate - node (v16.17.1, x64)
Memory used 546,950k (± 0.02%) 546,501k (± 0.03%) -449k (- 0.08%) 546,331k 546,751k p=0.005 n=6
Parse Time 4.77s (± 0.54%) 4.39s (± 0.75%) 🟩-0.38s (- 7.96%) 4.35s 4.44s p=0.005 n=6
Bind Time 1.85s (± 0.22%) 1.82s (± 1.42%) -0.03s (- 1.89%) 1.80s 1.85s p=0.022 n=6
Check Time 3.07s (± 0.78%) 3.06s (± 0.73%) ~ 3.04s 3.10s p=0.517 n=6
Emit Time 0.09s (± 4.45%) 0.10s (± 5.76%) ~ 0.09s 0.10s p=0.282 n=6
Total Time 9.78s (± 0.45%) 9.36s (± 0.58%) 🟩-0.42s (- 4.29%) 9.30s 9.43s p=0.005 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52833 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey jakebailey closed this Feb 18, 2023
@jakebailey jakebailey deleted the just-scanner branch February 18, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants