Skip to content

Dev11_0000000_null_forward_iterators: Avoid Clang warnings, guard headers for C++17/20 #5654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2025
Merged

Dev11_0000000_null_forward_iterators: Avoid Clang warnings, guard headers for C++17/20 #5654

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e19827
Guard headers and suppress Clang warnings
YexuanXiao Jul 26, 2025
79a6b38
Gather 17/20 headers at the end, add missing `<string_view>`.
StephanTLavavej Aug 2, 2025
af01c41
Avoid aligned_union_t, avoid the warning.
StephanTLavavej Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions tests/std/tests/Dev11_0000000_null_forward_iterators/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright (c) Microsoft Corporation.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

#define _SILENCE_CXX23_ALIGNED_UNION_DEPRECATION_WARNING
#define _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING
#define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING

Expand All @@ -10,21 +9,28 @@
#include <cstring>
#include <deque>
#include <experimental/filesystem>
#include <filesystem>
#include <forward_list>
#include <iterator>
#include <list>
#include <map>
#include <new>
#include <regex>
#include <set>
#include <span>
#include <string>
#include <type_traits>
#include <unordered_map>
#include <unordered_set>
#include <vector>

#if _HAS_CXX17
#include <filesystem>
#include <string_view>
#endif // _HAS_CXX17

#if _HAS_CXX20
#include <span>
#endif // _HAS_CXX20

using namespace std;

// N3797 24.2.5 [forward.iterators]/2:
Expand Down Expand Up @@ -91,14 +97,14 @@ void test_iterator() {
}

{
aligned_union_t<0, FwdIt> au3;
aligned_union_t<0, FwdIt> au4;
alignas(FwdIt) unsigned char buf3[sizeof(FwdIt)];
alignas(FwdIt) unsigned char buf4[sizeof(FwdIt)];

FwdIt* p3 = reinterpret_cast<FwdIt*>(&au3);
FwdIt* p4 = reinterpret_cast<FwdIt*>(&au4);
memset(buf3, 0xCC, sizeof(FwdIt));
memset(buf4, 0xDD, sizeof(FwdIt));

memset(p3, 0xCC, sizeof(FwdIt));
memset(p4, 0xDD, sizeof(FwdIt));
FwdIt* p3 = reinterpret_cast<FwdIt*>(buf3);
FwdIt* p4 = reinterpret_cast<FwdIt*>(buf4);

new (p3) FwdIt{};
new (p4) FwdIt{};
Expand Down