Dev11_0000000_null_forward_iterators: Avoid Clang warnings, guard headers for C++17/20
#5654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
changed the title
Dev11_0000000_null_forward_iterators: Avoid Clang warnings, guard headers for C++17/20
StephanTLavavej
approved these changes
Aug 2, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merged PR #117387 in Clang warnings when a parameter of memcpy is pointer to non-trivial-copyable types. This PR suppress the warning to avoid test failures.
Also, the
<filesystem>and<span>headers were not properly guarded, and this PR guards them as seen in L166 and L182. The above two issues would cause this test to fail.STL/tests/std/tests/Dev11_0000000_null_forward_iterators/test.cpp
Lines 166 to 168 in f015db5