Skip to content

Reduce vector algorithms test run time with ASan #5425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025
Merged

Reduce vector algorithms test run time with ASan #5425

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d62380
optimize LKG search and find_end
AlexGuteniev Apr 22, 2025
676c398
Merge branch 'main' into hotspot
StephanTLavavej Apr 23, 2025
903eb1f
is_eq => is_equal
StephanTLavavej Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions tests/std/tests/VSO_0000000_vector_algorithms/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,19 @@ auto last_known_good_find_first_of(FwdItH h_first, FwdItH h_last, FwdItN n_first

template <class RanItH, class RanItN>
auto last_known_good_search(RanItH h_first, RanItH h_last, RanItN n_first, RanItN n_last) {
const auto n_len = n_last - n_first;
const ptrdiff_t n_len = n_last - n_first;

for (; h_last - h_first >= n_len; ++h_first) {
if (equal(h_first, h_first + n_len, n_first, n_last)) {
bool is_equal = true;

for (ptrdiff_t i = 0; i != n_len; ++i) {
if (*(h_first + i) != *(n_first + i)) {
is_equal = false;
break;
}
}

if (is_equal) {
return h_first;
}
}
Expand All @@ -284,7 +293,7 @@ auto last_known_good_search(RanItH h_first, RanItH h_last, RanItN n_first, RanIt

template <class RanItH, class RanItN>
auto last_known_good_find_end(RanItH h_first, RanItH h_last, RanItN n_first, RanItN n_last) {
const auto n_len = n_last - n_first;
const ptrdiff_t n_len = n_last - n_first;

if (n_len > h_last - h_first) {
return h_last;
Expand All @@ -293,7 +302,16 @@ auto last_known_good_find_end(RanItH h_first, RanItH h_last, RanItN n_first, Ran
auto h_mid = h_last - n_len;

for (;;) {
if (equal(h_mid, h_mid + n_len, n_first, n_last)) {
bool is_equal = true;

for (ptrdiff_t i = 0; i != n_len; ++i) {
if (*(h_mid + i) != *(n_first + i)) {
is_equal = false;
break;
}
}

if (is_equal) {
return h_mid;
}

Expand Down