Reduce vector algorithms test run time with ASan #5425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid calling equal in a loop. Similar to microsoft#4654
StephanTLavavej
approved these changes
Apr 23, 2025
|
Thanks! 😻 This makes a big difference - on my 5950X, with an ASan build of the STL and ASan tests, I measured a reduction from 152.44 seconds to 96.21 seconds, for a speedup of 1.58x. I removed the ASan label because this isn't necessarily ASan-specific though. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for speeding up this test of how you've sped up the library! 🚀 ⏱️ 🧑🔬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize LKG
searchandfind_end.Avoid calling
equalin a loop.Similar to #4654