Skip to content

Conversation

Ashad001
Copy link
Contributor

Fix #3779

@Ashad001 Ashad001 requested a review from a team as a code owner June 19, 2023 09:32
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment:

// per LWG-3940

@Ashad001
Copy link
Contributor Author

One more comment:

// per LWG-3940

Done

@Ashad001
Copy link
Contributor Author

@microsoft-github-policy-service agree

@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Jun 19, 2023
@StephanTLavavej StephanTLavavej self-assigned this Jun 22, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit f6d61a8 into microsoft:main Jun 22, 2023
@StephanTLavavej
Copy link
Member

Thanks for updating these comments - and congratulations on your first microsoft/STL commit! 🚀 🎉 😻

This will ship in VS 2022 17.8 Preview 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up comments for LWG-3940 std::expected<void, E>::value() also needs E to be copy constructible
4 participants