Skip to content
This repository was archived by the owner on Nov 25, 2024. It is now read-only.

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Apr 21, 2023

This is a step towards allowing arbitrary room version impls.

@kegsay kegsay added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Apr 21, 2023
@kegsay kegsay requested a review from a team as a code owner April 21, 2023 13:41
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 28.57% and project coverage change: -0.15 ⚠️

Comparison is base (1647213) 66.72% compared to head (2d3a9d7) 66.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3064      +/-   ##
==========================================
- Coverage   66.72%   66.58%   -0.15%     
==========================================
  Files         495      495              
  Lines       53558    53559       +1     
==========================================
- Hits        35737    35661      -76     
- Misses      14176    14252      +76     
- Partials     3645     3646       +1     
Flag Coverage Δ
unittests 47.07% <28.57%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
federationapi/routing/invite.go 45.09% <0.00%> (-2.28%) ⬇️
roomserver/version/version.go 52.94% <20.00%> (-23.53%) ⬇️
clientapi/routing/capabilities.go 100.00% <100.00%> (ø)

... and 34 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Base automatically changed from kegan/redact-roomverimpl to main April 21, 2023 16:06
@kegsay kegsay merged commit 4679098 into main Apr 24, 2023
@kegsay kegsay deleted the kegan/iroomversion branch April 24, 2023 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants