Add RoomVersionImpl and use it #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was always true, so therefore useless. Add more useful helper functions for checking known room versions.
This removes the need for err checking so much.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## kegan/ver-int-redact #368 +/- ##
=======================================================
Coverage ? 52.16%
=======================================================
Files ? 37
Lines ? 5762
Branches ? 0
=======================================================
Hits ? 3006
Misses ? 2466
Partials ? 290 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
kegsay
added a commit
to matrix-org/dendrite
that referenced
this pull request
Apr 21, 2023
devonh
approved these changes
Apr 21, 2023
kegsay
added a commit
that referenced
this pull request
Apr 21, 2023
kegsay
added a commit
to matrix-org/dendrite
that referenced
this pull request
Apr 21, 2023
As outlined in matrix-org/gomatrixserverlib#368 The main change Dendrite side is that `RoomVersion` no longer has any methods on it. Instead, you need to bounce via `gmsl.GetRoomVersion`. It's very interesting to see where exactly Dendrite cares about this. For some places it's creating events (fine) but others are way more specific. Those areas will need to migrate to GMSL at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #367