set MLN_WITH_OPENGL=OFF by default, like Metal/Vulkan #3772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bloaty Results 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3772-compared-to-main.txtCompared to d387090 (legacy) Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3772-compared-to-legacy.txt |
|
Benchmark Results ⚡ Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3772-compared-to-main.txt |
birkskyum
changed the title
louwers
approved these changes
Aug 30, 2025
|
Might need to update CMakePresets.json. But good to merge if CI passes. |
Bloaty Results (iOS) 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3772-compared-to-main.txt |
|
All pass, except for Windows MSYS2 CI, which appear to fail because of MSYS2's toolchain is linking both static (libz.a, libstdc++.a) and dynamic (libz.dll.a) versions, causing duplicate symbols. I don't think it's caused by this PR - has it been reported before? Setting the --allow-multiple-definitions doesn´t seem to resolve it. |
|
Yes it is a known issue. #3670 |
birkskyum
force-pushed
the
set-MLN_WITH_OPENGL-and-METAL-off-by-default
branch
from
0bb4302 to
964e685
Compare
TimSylvester
added a commit
to WetDogWeather/maplibre-gl-native
that referenced
this pull request
Sep 3, 2025
* main: Create macOS amalgamation for core releases (maplibre#3768) Add weak pointer handling (maplibre#3763) Temporarily disable Windows CI (maplibre#3775) chore(ci): pin actions to shas (maplibre#3769) Fix compile error when building with MLN_USE_TRACY (maplibre#3774) set MLN_WITH_OPENGL=OFF by default, like Metal/Vulkan (maplibre#3772) Tweak Linux amalgamation (maplibre#3767) Tweak layer depth distribution (maplibre#3738) Add Sentry build tags (maplibre#3765) Release MapLibre Android 11.13.1 (maplibre#3761) Release MapLibre iOS 6.18.1 (maplibre#3762) Add weak pointer management to RasterSource and derived classes (maplibre#3726) Fix UB in TaggedString constructor (maplibre#3748) Add Compose Multiplatform section to README (maplibre#3751) format Bazel files with buildifier (maplibre#3756) use separate install-sccache script (maplibre#3755) Fix Android backend cleanup (maplibre#3681) # Conflicts: # include/mbgl/style/sources/raster_dem_source.hpp # include/mbgl/style/sources/vector_source.hpp # platform/ios/BUILD.bazel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid issues like these
Simply make OpenGL Opt-In like Metal and Vulkan are.
Until now, to build with e.g. Metal, you had to opt into Metal (MLN_WITH_METAL=ON), but a number of issues would occur if you forget to also opt-out of OpenGL (MLN_WITH_OPENGL=OFF). This removes the need for opting out.
Added MLN_WITH_OPENGL=ON to Qt, Node CI and Android App which didn't have explicit setting of the flag.
Also change a few "else // OpenGL" to "elif OPENGL", for strict conditional logic